New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 887409 link

Starred by 0 users
Status: Fixed
Owner:
█ vabr@chromium.org
hobby only
Closed: Oct 2
Cc:
dvadym@chromium.org
vasi...@chromium.org
jdoerrie@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

No PasswordStore metrics reported from iOS

Project Member Reported by vabr@chromium.org, Sep 20 
PasswordStore::ReportMetrics is not called from iOS. It is called from the constructor of ChromePasswordManagerClient on other platforms.

Unless we have a good reason not to gather metrics about stored logins on iOS, we can likely add a similar call to the IOSChromePasswordManager's constructor. Adding a few people in Cc who might have opinions or remember in case this omission is on purpose.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f92e4da286389b2ef5e8dc6ecfd1c4c302d9410a

commit f92e4da286389b2ef5e8dc6ecfd1c4c302d9410a
Author: Vaclav Brozek <vabr@chromium.org>
Date: Mon Oct 01 19:00:24 2018

Improve PasswordStore metrics reporting

This CL does the following changes to the code used by
ChromePasswordManagerClient:

(1) Extracts its platform-independent part into the core component.
    This will be useful when adding these metrics to iOS.
(2) Adds tests for that code.
(3) Replaces an obsolete guard against race-conditions with a
    thread-safe singleton pattern making use of modern C++.

Bug:  887409 
Change-Id: Ie9ad57d75df3bcebf491aa3f32c5f4919ca93f5b
Reviewed-on: https://chromium-review.googlesource.com/1251543
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595489}
[modify] https://crrev.com/f92e4da286389b2ef5e8dc6ecfd1c4c302d9410a/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/f92e4da286389b2ef5e8dc6ecfd1c4c302d9410a/components/password_manager/core/browser/BUILD.gn
[add] https://crrev.com/f92e4da286389b2ef5e8dc6ecfd1c4c302d9410a/components/password_manager/core/browser/store_metrics_reporter.cc
[add] https://crrev.com/f92e4da286389b2ef5e8dc6ecfd1c4c302d9410a/components/password_manager/core/browser/store_metrics_reporter.h
[add] https://crrev.com/f92e4da286389b2ef5e8dc6ecfd1c4c302d9410a/components/password_manager/core/browser/store_metrics_reporter_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/533dfdf65940bc18937aa0f7be1f384344a97f73

commit 533dfdf65940bc18937aa0f7be1f384344a97f73
Author: Vaclav Brozek <vabr@chromium.org>
Date: Tue Oct 02 09:30:40 2018

Report PasswordStore metrics on iOS

On non-iOS platforms, the PasswordStore reports metrics about the
usage of password manager on every start. For iOS, all the pieces are
there, but have not been used.

This CL adds the reporting on iOS.

Bug:  887409 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Icef32ced5cbc7e61776e0f1ca41466d4ef65f032
Reviewed-on: https://chromium-review.googlesource.com/1255523
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595773}
[modify] https://crrev.com/533dfdf65940bc18937aa0f7be1f384344a97f73/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm

Comment 3 by vabr@chromium.org, Oct 2

Owner: vabr@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment