New issue
Advanced search Search tips

Issue 887390 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 0
Type: Bug



Sign in to add a comment

Update two WebAuthn error message strings

Project Member Reported by engedy@chromium.org, Sep 20

Issue description

In the string:

  "We couldn't verify your identity on this device"

it could be quite unclear for users who “we” refers to. Is it Chrome? Is it the website? Or some other party? Suggestion:

  “Your identity couldn’t be verified”

In context, the phrase “on this device” might not be needed either.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25a5ed92ebf8637ad86512d7beb440bc04008fdb

commit 25a5ed92ebf8637ad86512d7beb440bc04008fdb
Author: Balazs Engedy <engedy@chromium.org>
Date: Thu Sep 20 19:49:34 2018

Update WebAuthn two error strings.

Replace "We couldn't verify your identity on this device" with the
string “Your identity couldn’t be verified”.

Bug:  887390 
Change-Id: I4e2885f68964a2706f58a27a3dba3dbe412bbcf3
Reviewed-on: https://chromium-review.googlesource.com/1236002
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592911}
[modify] https://crrev.com/25a5ed92ebf8637ad86512d7beb440bc04008fdb/chrome/app/generated_resources.grd

Labels: -M70 Merge-Request-70 M-70
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 21

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 24 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 22

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bd7fd0ff3471b962198862be48f179def76397e

commit 7bd7fd0ff3471b962198862be48f179def76397e
Author: Balazs Engedy <engedy@chromium.org>
Date: Sat Sep 22 07:15:12 2018

Update WebAuthn two error strings.

Replace "We couldn't verify your identity on this device" with the
string “Your identity couldn’t be verified”.

Bug:  887390 
Change-Id: I4e2885f68964a2706f58a27a3dba3dbe412bbcf3
Reviewed-on: https://chromium-review.googlesource.com/1236002
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592911}(cherry picked from commit 25a5ed92ebf8637ad86512d7beb440bc04008fdb)
Reviewed-on: https://chromium-review.googlesource.com/1238915
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#582}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/7bd7fd0ff3471b962198862be48f179def76397e/chrome/app/generated_resources.grd

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/7bd7fd0ff3471b962198862be48f179def76397e

Commit: 7bd7fd0ff3471b962198862be48f179def76397e
Author: engedy@chromium.org
Commiter: engedy@chromium.org
Date: 2018-09-22 07:15:12 +0000 UTC

Update WebAuthn two error strings.

Replace "We couldn't verify your identity on this device" with the
string “Your identity couldn’t be verified”.

Bug:  887390 
Change-Id: I4e2885f68964a2706f58a27a3dba3dbe412bbcf3
Reviewed-on: https://chromium-review.googlesource.com/1236002
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592911}(cherry picked from commit 25a5ed92ebf8637ad86512d7beb440bc04008fdb)
Reviewed-on: https://chromium-review.googlesource.com/1238915
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#582}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Labels: Needs-Feedback
Able to verify this fix on mac 10.13.6 touch bar using 70.0.3538.35.But we are not able to reproduce this on Linux and windows.Could you please provide steps to reproduce the issue on Linux & windows.

@engedy: Could you please help us verifying the fix on linux and windows.

Thanks!
Buildwithfix_MacOS.webm
10.9 MB View Download
TouchID is macOS only, so I'd say that's been tested as well as it could.

On other platform, to exercise the new string, just delete all registrations (by clicking the trashbin icon) on the demo site, click "Authenticate", and touch your security key.
I mean: touch your USB security key.
engedy@, thank you for the quick update.
Manoranjan, let us know if you need any more info.

Sign in to add a comment