New issue
Advanced search Search tips

Issue 887350 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Changing `background-clip` In Developer Tools Has No Effect

Reported by swsevera...@gmail.com, Sep 20

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Steps to reproduce the problem:
1. Open the following as an HTML document, which will display an element whose background is clipped at its `padding-box`. Meaning, the element's background does not extend beyond its `padding-box`:

<!DOCTYPE html>
<html lang="en">

<head>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <meta http-equiv="X-UA-Compatible" content="ie=edge">
  <title>Document</title>
  <style>
    .test {
      height: 200px;
      width: 200px;
      background: blue;
      border: 10px dashed red;
      background-clip: padding-box;
    }
  </style>
</head>

<body>
  <div class="test"></div>
</body>

</html>

2. Observe the white spaces between each the border's red dashes.
3. Open Developer Tools and attempt to change the element's `background-clip` property to `border-box`. Observe that the appearance of the element's border does not change at all.

What is the expected behavior?
Changing the element's `background-clip` to `border-box` should result in the blue background being clipped at the edge of the element's border box. Therefore, there should be blue spaces between each red space of the border.

What went wrong?
Changing the element's `background-clip` value via Devtools had no observable effect

Did this work before? N/A 

Chrome version: 68.0.3440.106  Channel: n/a
OS Version: OS X 10.13.6
Flash Version:
 
Screen Shot 2018-09-20 at 6.43.32 AM.png
225 KB View Download
Labels: Needs-Milestone
Cc: mstensho@chromium.org vamshi.kommuri@chromium.org
Labels: -Type-Bug -Pri-2 Triaged-ET RegressedIn-65 Target-70 Target-71 M-71 FoundIn-71 FoundIn-70 hasbisect Target-69 FoundIn-69 OS-Linux OS-Windows Pri-1 Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)
Thanks for filing the issue!

Able to reproduce the issue on reported chrome version 68.0.3440.106 and on the latest canary 71.0.3558.0 using Ubuntu 14.04, Windows 10 and Mac 10.13.1

Bisect Information:
-------------------
Good Build: 65.0.3291.0
Bad Build:  65.0.3293.0
Note: Version 65.0.3292.0 is showing black UI

Changelog:
https://chromium.googlesource.com/chromium/src/+log/65.0.3291.0..65.0.3293.0?pretty=fuller&n=10000
suspecting:
https://chromium-review.googlesource.com/c/chromium/src/+/822094
or
https://chromium-review.googlesource.com/c/chromium/src/+/817994

Note: Unable to provide per revision bisect as invoked builds are crashing or showing black UI.
@Morten Stenshorne: Please help in assigning it to the right owner if this isn't related to your change.

Cc: chrishtr@chromium.org
Both those commits just update tests, no code changes. So it has to be something else. Probably something for the paint team to figure out.
Components: -Platform>DevTools Platform>DevTools>Authoring
Owner: futhark@chromium.org
Status: Assigned (was: Untriaged)
My bisect landed to this commit: https://chromium.googlesource.com/chromium/src/+/c34e49dbb593ee21366901e1d6b47dc8123974a4
"FillLayer::VisuallyEqual incorrect comparison when first layer is none."

Components: Blink>CSS
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/550fc89a96af43ac1a8286b63e45a0484af64cbd

commit 550fc89a96af43ac1a8286b63e45a0484af64cbd
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Sep 24 13:55:43 2018

Visual change on background-clip changes.

The background-clip property affects background-color visually, so we
need to say a layer is visually different even without an image.

We had a wpt test for this which had a stray line which made the test
always pass.

Bug:  887350 
Change-Id: Icc585f9e631485970b6509e015eff1e2007e4f0b
Reviewed-on: https://chromium-review.googlesource.com/1238448
Reviewed-by: Anders Ruud <andruud@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593523}
[modify] https://crrev.com/550fc89a96af43ac1a8286b63e45a0484af64cbd/third_party/WebKit/LayoutTests/external/wpt/css/css-backgrounds/background-clip-color-repaint.html
[modify] https://crrev.com/550fc89a96af43ac1a8286b63e45a0484af64cbd/third_party/blink/renderer/core/style/fill_layer.cc

Status: Fixed (was: Started)

Sign in to add a comment