Issue metadata
Sign in to add a comment
|
Regression: [Devtools] NTP page doesnot load properly in emulation mode.
Reported by
pranjali...@etouch.net,
Sep 20
|
||||||||||||||||||||||
Issue descriptionChrome Version: 71.0.3557.0 (Official Build) 409ad95fbafba7ca90dc799c9a0be24d3abb549f-refs/branch-heads/3557@{#1}(32/64-bit) OS: Windows(7,8,8.1,10) and Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14). What steps will reproduce the problem? 1. Launch chrome and open NTP. 2.Open devtools and click on 'Toggle device toolbar'. 3.Observe. Actual Result: NTP page doesnot load properly in emulation mode. Expected Result: NTP page doesnot load properly in emulation mode. This is regression issue broken in ‘M-71’ and below is bisect info, Good build: 71.0.3552.3 Bad build : 71.0.3553.0 You are probably looking for a change made after 591429 (known good), but no later than 591430 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/d91dacc021d5d48160bce4a3e367da53b97fe719..432553b5cb40dde1ae7ac1817dc7e2deecbf8e4e Suspecting: https://chromium.googlesource.com/chromium/src/+/432553b5cb40dde1ae7ac1817dc7e2deecbf8e4e @bokan: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly review the attached screen-cast for reference. Thank you. Note: Issue is not seen on Linux(14.04 LTS)
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb643a6b869cf13fc8a00a7c259073925c531434 commit eb643a6b869cf13fc8a00a7c259073925c531434 Author: David Bokan <bokan@chromium.org> Date: Mon Sep 24 14:58:14 2018 Revert "Improve rotation check on viewport resize" This reverts commit 432553b5cb40dde1ae7ac1817dc7e2deecbf8e4e. Reason for revert: width == height isn't enough since the system bar affects only height. Broke 887064, 887330, 887899 Original change's description: > Improve rotation check on viewport resize > > Since rotation used to be supported only on Android, where windows can't > be resized, we made the assumption that if the width changes it must be > a rotation. > > This changes in ChromeOS where entering tablet mode enables rotation but > also resizes the window (when entering tablet mode). This caused > inappropriate rotation anchoring. > > The underlying issue has been fixed in other patches linked to this bug, > the rotation trigger should be improved to check that the width and > height are swapped. > > Bug: 831473 > Change-Id: I0acd39d16319d8cb7819faac4c4ce54b6f7a2e46 > Reviewed-on: https://chromium-review.googlesource.com/1224711 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591430} TBR=bokan@chromium.org,dtapuska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831473 ,887899, 887064 , 887330 Change-Id: Ib0f3cad366a80506effc62fcc352e1c75f2fcd55 Reviewed-on: https://chromium-review.googlesource.com/1239726 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593536} [modify] https://crrev.com/eb643a6b869cf13fc8a00a7c259073925c531434/third_party/blink/renderer/core/exported/web_view_impl.cc [modify] https://crrev.com/eb643a6b869cf13fc8a00a7c259073925c531434/third_party/blink/renderer/core/frame/rotation_viewport_anchor_test.cc [modify] https://crrev.com/eb643a6b869cf13fc8a00a7c259073925c531434/third_party/blink/renderer/core/html/image_document.h [modify] https://crrev.com/eb643a6b869cf13fc8a00a7c259073925c531434/third_party/blink/renderer/core/html/image_document_test.cc
,
Oct 2
pranjali.mahabdi@ please verify the fix in latest canary.
,
Oct 2
CL in question was reverted. Please verify in Canary. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Sep 20