Convert AdvancedProtectionStatusManager unittest away from using FakeProfileOAuth2TokenService |
||
Issue descriptionShould be done once the production code is converted away from ProfileOAuth2TokenService.
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1339be2a6b0a7dffc48a40ef7fed4e0ba53273ff commit 1339be2a6b0a7dffc48a40ef7fed4e0ba53273ff Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Nov 08 13:14:51 2018 [s13n] Convert AdvancedProtectionStatusManagerTest away from FakeProfileOAuth2TokenService This CL is a continuation of [1], where AdvancedProtectionStatusManager (production code) was migrated from SigninManager and OAuth2TokenService to IdentityManager. At this time the respective unittests are migrated. The CL adds the adds/changes the following testing APIs: - IdentityTestEnvironment::WaitForAccessTokenRequestIfNecessaryAndRespondWithToken receives an extra (optional) parameter |id_token|, and forward it to FakeProfileOAuth2TokenService::IssueAllTokensForAccount. This allows the body of AdvancedProtectionStatusManagerTest::MakeOAuthTokenFetchSucceed to be migrated flawlessly. - IdentityTestEnvironment::UpdateAccountInfoForAccount. This method updates the account information for a given known account, by calling AccountTrackerService::SeedAccountInfo. [1] https://crrev.com/c/1250968 BUG= 887266 Change-Id: Ica84fd299794552f2ae6957dfc6c7dde6bba7afa Reviewed-on: https://chromium-review.googlesource.com/c/1308993 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#606440} [modify] https://crrev.com/1339be2a6b0a7dffc48a40ef7fed4e0ba53273ff/chrome/browser/safe_browsing/advanced_protection_status_manager_unittest.cc [modify] https://crrev.com/1339be2a6b0a7dffc48a40ef7fed4e0ba53273ff/services/identity/public/cpp/identity_test_environment.cc [modify] https://crrev.com/1339be2a6b0a7dffc48a40ef7fed4e0ba53273ff/services/identity/public/cpp/identity_test_environment.h [modify] https://crrev.com/1339be2a6b0a7dffc48a40ef7fed4e0ba53273ff/services/identity/public/cpp/identity_test_utils.cc [modify] https://crrev.com/1339be2a6b0a7dffc48a40ef7fed4e0ba53273ff/services/identity/public/cpp/identity_test_utils.h
,
Nov 8
|
||
►
Sign in to add a comment |
||
Comment 1 by toniki...@chromium.org
, Oct 30Status: Started (was: Available)