New issue
Advanced search Search tips

Issue 887258 link

Starred by 1 user
Status: Fixed
Owner:
ioanap@chromium.org
Closed: Sep 28
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocking:
issue 856180



Sign in to add a comment

Add keyboard accessory shadow and fix padding and vertical text alignment

Project Member Reported by ioanap@chromium.org, Sep 20 
In order to make the keyboard accessory comply with the latest specs the following elements need to be changed:

- Add drop shadow.
- Add a divider at the top of the accessory sheet.
- Center text vertically in the options offered by the accessory sheet.

Comment 1 by ioanap@chromium.org, Sep 20

Blocking: 856180
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e6b81dba717bd2c4b9947754609570b5c21ac80

commit 8e6b81dba717bd2c4b9947754609570b5c21ac80
Author: Ioana Pandele <ioanap@chromium.org>
Date: Thu Sep 20 09:02:52 2018

Update keyboard accessory style to match specs (part 2)

Changes in this CL:
- added a drop shadow
- added a divider at the top of the accessory sheet
- centered text for accessory options (e.g. Manage passwords...)

Bug:  856180 ,  887258 
Change-Id: I7b71670ef551d8d5f86501ba47011ae590323676
Reviewed-on: https://chromium-review.googlesource.com/1225803
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592727}
[modify] https://crrev.com/8e6b81dba717bd2c4b9947754609570b5c21ac80/chrome/android/java/res/layout/keyboard_accessory.xml
[modify] https://crrev.com/8e6b81dba717bd2c4b9947754609570b5c21ac80/chrome/android/java/res/layout/main.xml
[modify] https://crrev.com/8e6b81dba717bd2c4b9947754609570b5c21ac80/chrome/android/java/res/layout/password_accessory_sheet_label.xml
[modify] https://crrev.com/8e6b81dba717bd2c4b9947754609570b5c21ac80/chrome/android/java/res/layout/password_accessory_sheet_option.xml
[add] https://crrev.com/8e6b81dba717bd2c4b9947754609570b5c21ac80/chrome/android/java/res/layout/password_accessory_sheet_top_divider.xml
[modify] https://crrev.com/8e6b81dba717bd2c4b9947754609570b5c21ac80/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/8e6b81dba717bd2c4b9947754609570b5c21ac80/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryData.java
[modify] https://crrev.com/8e6b81dba717bd2c4b9947754609570b5c21ac80/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java
[modify] https://crrev.com/8e6b81dba717bd2c4b9947754609570b5c21ac80/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewBinder.java
[modify] https://crrev.com/8e6b81dba717bd2c4b9947754609570b5c21ac80/chrome/browser/password_manager/password_accessory_controller.cc
[modify] https://crrev.com/8e6b81dba717bd2c4b9947754609570b5c21ac80/chrome/browser/password_manager/password_accessory_controller_unittest.cc
[modify] https://crrev.com/8e6b81dba717bd2c4b9947754609570b5c21ac80/chrome/browser/password_manager/password_accessory_view_interface.h

Comment 3 by ioanap@chromium.org, Sep 28

Status: Fixed (was: Started)
KAStyleUpdate2.png
98.9 KB View Download
►

Sign in to add a comment