New issue
Advanced search Search tips

Issue 887245 link

Starred by 2 users
Status: Fixed
Owner:
svil...@igalia.com
Closed: Oct 2
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Convert ProfilesState to talk to IdentityManager rather than ProfileOAuth2TokenService

Project Member Reported by blundell@chromium.org, Sep 20 
It calls PO2TS::GetAccounts(); this can be converted to IdentityManager::GetAccountsWithRefreshTokens().

Comment 1 by svil...@igalia.com, Sep 26

Owner: svil...@igalia.com
Status: Assigned (was: Available)
I'm taking this
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2cceb55302a6bd1352dcb385f10b68df3d4e007

commit b2cceb55302a6bd1352dcb385f10b68df3d4e007
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Tue Oct 02 08:44:55 2018

Migrate ProfilesState to use IdentityManager

Users of ProfileOAuth2TokenService should use instead the
IdentityManager API so that they could eventually use the identity
service.

Bug:  887245 
Change-Id: I2ac628d92759488530ee699d438dea920b8b6a9b
Reviewed-on: https://chromium-review.googlesource.com/1245784
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595761}
[modify] https://crrev.com/b2cceb55302a6bd1352dcb385f10b68df3d4e007/chrome/browser/profiles/profiles_state.cc
[modify] https://crrev.com/b2cceb55302a6bd1352dcb385f10b68df3d4e007/chrome/browser/profiles/profiles_state.h
[modify] https://crrev.com/b2cceb55302a6bd1352dcb385f10b68df3d4e007/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Comment 3 by svil...@igalia.com, Oct 2

Status: Fixed (was: Assigned)
Can be closed now
►

Sign in to add a comment