New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 887235 link

Starred by 2 users
Status: Fixed
Owner:
dtseng@chromium.org
Closed: Nov 28
Cc:
dtseng@chromium.org
ajha@chromium.org
lpalmaro@chromium.org
█ jamwalla@chromium.org
█ kjbooker@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-10-17
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Regression: Chrome crashes on enabling & disabling the toggle button of Chromevox(spoken feedback) continuously

Project Member Reported by rkalavakuntla@chromium.org, Sep 20 
Chrome Version: 71.0.3555.0/11081.0.0 dev channel Blaze,Paine,Candy
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover build >> In OOBE screen ->Accessibility Settings 
(2)Keep tab focus on the toggle button of Chromevox(spoken feedback)
(3)enable & disable the toggle button of Chromevox(spoken feedback) continuously and also increase/decrease the volume alongside and observe crash

Actual: Chrome crashes on enabling & disabling the toggle button of Chromevox(spoken feedback) continuously 
Expected: Chrome shouldn't crash on enabling & disabling the toggle button of Chromevox(spoken feedback) continuously 

This is a Regression issue as same is working fine in M-69

Note: 
1.Unable to get the crash id's in OOBE screen
2.Issue is also seen in 70.0.3538.22 dev and Dev RC #71.0.3554.0/ 11078.0.0 

Attached the screencast for reference..
Crash.mp4
8.6 MB View Download

Comment 1 by leberly@chromium.org, Sep 21 

I tried this in 69.0.3497.95 in Eve, turning off and on 20 times in a row and changing the volume didn't reproduce the bug.

Now updating to 71 and trying again.

Comment 2 by leberly@chromium.org, Sep 21

Labels: Needs-Feedback
Owner: rkalavakuntla@chromium.org
Status: Assigned (was: Untriaged)
I am unable to reproduce this on 71.0.3555.0 Canary channel on Eve using the steps listed above and shown in the video. I turned ChromeVox off and on in the Accessibility Settings menu 40 times in a row while simultaneously adjusting he volume using the volume keys. Perhaps this is hardware dependent?

Comment 3 by rkalavakuntla@chromium.org, Sep 24

Labels: -Needs-Feedback
Owner: leberly@chromium.org
Tested the issue on 71.0.3558.0/11093.0.0 dev channel Daisy,Reks & Kip and able to reproduce the bug consistently with the steps mentioned in Comment #0.
Thanks!

Comment 4 by leberly@chromium.org, Sep 24

Cc: lpalmaro@chromium.org kjbooker@chromium.org dtseng@chromium.org
Owner: dtseng@chromium.org
Status: Available (was: Assigned)
Hi David T,

I don't have access to Daisy, Reks, nor Kip for testing. Please see if you can repro this Release block stable crash. I'm unable to repro on Eve. 

Thanks,

Laura

Comment 5 by dtseng@chromium.org, Oct 4

Labels: -ReleaseBlock-Stable -Inhouse-HYD-Reported
zzI can't reproduce this either. Unfortunately, without a crash log, I can't do much with this report.

Comment 6 by dtseng@chromium.org, Oct 17

NextAction: 2018-10-17
Status: Started (was: Available)
I can repro this now. Fix is in review.

Comment 7 by msw@chromium.org, Oct 18 

This looks a lot like Issue 887380, perhaps one is a dup of the other?

Comment 8 by msw@chromium.org, Oct 18

Cc: jamwalla@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01a2d8ab84c37ee250db4fe0314776b81b0cf24a

commit 01a2d8ab84c37ee250db4fe0314776b81b0cf24a
Author: David Tseng <dtseng@chromium.org>
Date: Thu Oct 18 21:48:47 2018

Fixes potential crash when toggling accessibility services

Bug:  887235 
Change-Id: Id5aed4e8030ae0d8db02d369bf61772444b441ad
Reviewed-on: https://chromium-review.googlesource.com/c/1286905
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600924}
[modify] https://crrev.com/01a2d8ab84c37ee250db4fe0314776b81b0cf24a/chrome/browser/chromeos/accessibility/spoken_feedback_event_rewriter_delegate.cc
[modify] https://crrev.com/01a2d8ab84c37ee250db4fe0314776b81b0cf24a/chrome/browser/chromeos/accessibility/switch_access_event_handler.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 22

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/642cdd6203bd99c91bc7e08b62b04a0845845b1f

commit 642cdd6203bd99c91bc7e08b62b04a0845845b1f
Author: David Tseng <dtseng@chromium.org>
Date: Mon Oct 22 15:40:26 2018

Merge to 71: Fixes potential crash when toggling accessibility services

Bug:  887235 ,890907
Change-Id: Id5aed4e8030ae0d8db02d369bf61772444b441ad
Reviewed-on: https://chromium-review.googlesource.com/c/1286905
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600924}(cherry picked from commit 01a2d8ab84c37ee250db4fe0314776b81b0cf24a)
Reviewed-on: https://chromium-review.googlesource.com/c/1293759
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#208}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/642cdd6203bd99c91bc7e08b62b04a0845845b1f/chrome/browser/chromeos/accessibility/spoken_feedback_event_rewriter_delegate.cc
[modify] https://crrev.com/642cdd6203bd99c91bc7e08b62b04a0845845b1f/chrome/browser/chromeos/accessibility/switch_access_event_handler.cc
Project Member

Comment 11 by cr-audit...@appspot.gserviceaccount.com, Oct 22

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/c7ae0527c708f779bbc0d1b3736ee38d1b57304d

Commit: c7ae0527c708f779bbc0d1b3736ee38d1b57304d
Author: dtseng@chromium.org
Commiter: dtseng@chromium.org
Date: 2018-10-22 16:32:43 +0000 UTC

Merge to 70: Fixes potential crash when toggling accessibility services

(cherry picked from commit 01a2d8ab84c37ee250db4fe0314776b81b0cf24a)

Bug:  887235 ,890907
Change-Id: Id5aed4e8030ae0d8db02d369bf61772444b441ad
Reviewed-on: https://chromium-review.googlesource.com/c/1286905
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600924}
Reviewed-on: https://chromium-review.googlesource.com/c/1294014
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#1023}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 22

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7ae0527c708f779bbc0d1b3736ee38d1b57304d

commit c7ae0527c708f779bbc0d1b3736ee38d1b57304d
Author: David Tseng <dtseng@chromium.org>
Date: Mon Oct 22 16:32:43 2018

Merge to 70: Fixes potential crash when toggling accessibility services

(cherry picked from commit 01a2d8ab84c37ee250db4fe0314776b81b0cf24a)

Bug:  887235 ,890907
Change-Id: Id5aed4e8030ae0d8db02d369bf61772444b441ad
Reviewed-on: https://chromium-review.googlesource.com/c/1286905
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600924}
Reviewed-on: https://chromium-review.googlesource.com/c/1294014
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#1023}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/c7ae0527c708f779bbc0d1b3736ee38d1b57304d/chrome/browser/chromeos/accessibility/spoken_feedback_event_rewriter_delegate.cc
[modify] https://crrev.com/c7ae0527c708f779bbc0d1b3736ee38d1b57304d/chrome/browser/chromeos/accessibility/switch_access_event_handler.cc
Project Member

Comment 13 by cr-audit...@appspot.gserviceaccount.com, Oct 23

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/642cdd6203bd99c91bc7e08b62b04a0845845b1f

Commit: 642cdd6203bd99c91bc7e08b62b04a0845845b1f
Author: dtseng@chromium.org
Commiter: dtseng@chromium.org
Date: 2018-10-22 15:40:26 +0000 UTC

Merge to 71: Fixes potential crash when toggling accessibility services

Bug:  887235 ,890907
Change-Id: Id5aed4e8030ae0d8db02d369bf61772444b441ad
Reviewed-on: https://chromium-review.googlesource.com/c/1286905
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600924}(cherry picked from commit 01a2d8ab84c37ee250db4fe0314776b81b0cf24a)
Reviewed-on: https://chromium-review.googlesource.com/c/1293759
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#208}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Comment 14 by dtseng@chromium.org, Nov 28

Status: Fixed (was: Started)
►

Sign in to add a comment