New issue
Advanced search Search tips

Issue 887227 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression :[Print preview] Focus is not seen on 'Manage...' link after pressing 'Tab' key

Reported by rp...@etouch.net, Sep 20

Issue description

Chrome Version: 71.0.3557.0 (Official Build)Revision 409ad95fbafba7ca90dc799c9a0be24d3abb549f-refs/branch-heads/3557@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and press 'Ctrl + p' to open print preview
2. Click on 'Change' button to open 'Select a destination' overlay and press 'Tab' key and observe focus travel

Actual Result: Focus is not seen on 'Manage...' link after pressing 'Tab' key
Expected Result: Focus should be seen on 'Manage...' link after pressing 'Tab' key

This is regression issue broken in ‘M-71’ and will soon update other info:
Good build: 71.0.3556.0 
Bad build : 71.0.3557.0 
 
Actual_video.mp4
270 KB View Download
Expected_video.mp4
247 KB View Download
Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 592613 (known good), but no later than 592614 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/282b263f46a04b847af8ca36e359cb5c18574225..740492f9aba228edd794d7bd9d148d0929895a54

Suspect : https://chromium.googlesource.com/chromium/src/+/740492f9aba228edd794d7bd9d148d0929895a54

From the CL above, assigning the issue to the concern owner 

@rbpotter- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a12770d1657f8823f5e867bd3e60e8d2c05065b6

commit a12770d1657f8823f5e867bd3e60e8d2c05065b6
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Sep 21 16:07:04 2018

Print Preview Refresh: Fix destinations polish bugs

Fixing:
(1) Action links fell out of the tab order because destinations_dialog
and destinations_list were not correctly importing action_link.html
(2) Absolute positioning of icon to set it on top of the cr-input in
print_preview_search_box led to icon getting misplaced when browser
window size changed. Fix by adding a prefix in cr-input.
(3) Destination icon was shrinking for large font sizes due to using
flex layout. Make icon fixed size (20px, per spec).
(4) Ensure there is enough margin on the "Manage" link to show the
focus outline.

Bug:  884600 ,  885090 ,  886593 ,  887227 ,  887229 
Change-Id: Ic7d910ad1460e8d457186b9c189797f12db4de5f
Reviewed-on: https://chromium-review.googlesource.com/1237137
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593205}
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/print_preview_search_box.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/ui/webui/resources/cr_elements/cr_input/cr_input.html

Labels: TE-Verified-M71 TE-Verified-71.0.3559.0
Update :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6,10.14) using latest Canary build : 71.0.3559.0 and the issue is Fixed.Hence adding TE Verified Labels.

Kindly refer the attached screen cast.

Thank you..!!
Fixed_video.mp4
374 KB View Download
Status: Verified (was: Assigned)

Sign in to add a comment