New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 887225 link

Starred by 1 user
Status: Fixed
Owner:
█ kitching@chromium.org
Last visit > 30 days ago
Closed: Sep 20
Cc:
█ stagenut@chromium.org
█ kitching@chromium.org
haoweiw@chromium.org
johndhong@chromium.org
█ jrbarnette@chromium.org
█ gu...@chromium.org
dbasehore@chromium.org
█ bhthompson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

Pre-CQ ToT breakage: autotest: lab_inventory_unittest failing

Project Member Reported by nya@chromium.org, Sep 20 
Recent Pre-CQ runs are all failing:
https://cros-goldeneye.corp.google.com/chromeos/legoland/builderHistory?buildConfig=lakitu-no-vmtest-pre-cq&buildBranch=master

Error is:

autotest-0.0.2-r9759: ======================================================================
autotest-0.0.2-r9759: ERROR: test_broken (autotest_lib.site_utils.lab_inventory_unittest.HostSetInventoryTestCase)
autotest-0.0.2-r9759: Test counting for broken DUTs.
autotest-0.0.2-r9759: ----------------------------------------------------------------------
autotest-0.0.2-r9759: Traceback (most recent call last):
autotest-0.0.2-r9759:   File "/build/lakitu/tmp/portage/chromeos-base/autotest-0.0.2-r9759/work/autotest-0.0.2/site_utils/lab_inventory_unittest.py", line 108, in test_broken
autotest-0.0.2-r9759:     self._check_counts(0, 1, 0)
autotest-0.0.2-r9759:   File "/build/lakitu/tmp/portage/chromeos-base/autotest-0.0.2-r9759/work/autotest-0.0.2/site_utils/lab_inventory_unittest.py", line 95, in _check_counts
autotest-0.0.2-r9759:     self.assertEqual(self.histories.get_working(), working)
autotest-0.0.2-r9759:   File "/build/lakitu/tmp/portage/chromeos-base/autotest-0.0.2-r9759/work/autotest-0.0.2/site_utils/lab_inventory.py", line 244, in get_working
autotest-0.0.2-r9759:     return len(self.get_working_list())
autotest-0.0.2-r9759:   File "/build/lakitu/tmp/portage/chromeos-base/autotest-0.0.2-r9759/work/autotest-0.0.2/site_utils/lab_inventory.py", line 239, in get_working_list
autotest-0.0.2-r9759:     if _host_is_working(h)]
autotest-0.0.2-r9759:   File "/build/lakitu/tmp/portage/chromeos-base/autotest-0.0.2-r9759/work/autotest-0.0.2/site_utils/lab_inventory.py", line 161, in _host_is_working
autotest-0.0.2-r9759:     return _get_diagnosis(history).status == status_history.WORKING
autotest-0.0.2-r9759:   File "/build/lakitu/tmp/portage/chromeos-base/autotest-0.0.2-r9759/work/autotest-0.0.2/site_utils/lab_inventory.py", line 149, in _get_diagnosis
autotest-0.0.2-r9759:     and diagnosis.task.end_time < history.start_time):
autotest-0.0.2-r9759: AttributeError: 'NoneType' object has no attribute 'end_time'

I believe it's caused by chump of
https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1226921
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/91e4991dec0b98dba7b418b999a3a42ee05e4a25

commit 91e4991dec0b98dba7b418b999a3a42ee05e4a25
Author: Joel Kitching <kitching@chromium.org>
Date: Thu Sep 20 06:50:50 2018

Revert "[autotest] Fix idle DUT accounting in lab_inventory."

This reverts commit 59e9ced7d988897d871b45b02c9e97d240ef1b6e.

Reason for revert: Breaks all CQ builders (see  crbug.com/887225 )

Original change's description:
> [autotest] Fix idle DUT accounting in lab_inventory.
>
> In inventory runs, DUTs that were locked when broken were being
> accounted for as broken instead of idle, even if they hadn't done
> work over the inventory time interval.
>
> This changes handling so that DUTs that are locked will eventually
> be accounted for as idle rather than broken.
>
> BUG=None
> TEST=run manually with --debug.
>
> Change-Id: I38d521cbcde7de3cdc6f5368c0be8d3ef3f2f625
> Reviewed-on: https://chromium-review.googlesource.com/1226921
> Reviewed-by: Richard Barnette <jrbarnette@google.com>
> Tested-by: Richard Barnette <jrbarnette@google.com>

BUG= crbug.com/887225 
TEST=None

Change-Id: Id8d1c4968392543ad598781ac0bb8568b40fb5cc
Reviewed-on: https://chromium-review.googlesource.com/1235456
Reviewed-by: Joel Kitching <kitching@chromium.org>
Commit-Queue: Joel Kitching <kitching@chromium.org>
Tested-by: Joel Kitching <kitching@chromium.org>

[modify] https://crrev.com/91e4991dec0b98dba7b418b999a3a42ee05e4a25/site_utils/lab_inventory.py

Comment 2 by vapier@google.com, Sep 20

Components: -Infra>Client>ChromeOS>Build Infra>Client>ChromeOS>Test

Comment 3 by jrbarnette@chromium.org, Sep 20

Owner: kitching@chromium.org
Status: Fixed (was: Untriaged)
Given that the tree is now clean, I think we can call this fixed.

The corrected CL is here:
    https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1236779
►

Sign in to add a comment