Dynamic background-color value change of transparent img or same size parent strips it away altogether
Reported by
irina.mi...@springload.co.nz,
Sep 20
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36 Steps to reproduce the problem: https://codepen.io/anon/pen/oPJKRO https://codepen.io/anon/pen/xaMKZM 1. Have transparent img with background-color specified (or not) in a wrapper with background-color specified 2. Change img (or wrapper) background-color value dynamically (style or add css class) What is the expected behavior? background-color of transparent img and/or its wrapper painted correctly after a dynamic change of value What went wrong? Both img and wrapper background-colors will be painted transparent if wrapper is same size as img. Correct background-color can be forced by padding on elements, but will otherwise be treated as transparent. Did this work before? N/A Does this work in other browsers? Yes Chrome version: 69.0.3497.100 Channel: stable OS Version: OS X 10.13.6 Flash Version:
,
Sep 20
Able to reproduce the issue on Windows 10, mac 10.13.3 and Ubuntu 14.04 using chrome reported version #69.0.3497.100 and latest canary #71.0.3556.0. Bisect Information: ===================== Good build: 65.0.3306.0 Bad Build : 65.0.3308.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/b5cb183a5969fe36a0b2e64d2b6c60c4e9468d26..0a3e23b889a3b94d2a8f849069d53709dec8cbd3 From the above change log suspecting below change Change-Id: Ia4efbb18b2e41cd45882486e9863e6b2779798ca Reviewed-on: https://chromium-review.googlesource.com/845127 chrishtr@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks...!!
,
Oct 2
This has been fixed. I bisected it to: https://chromium.googlesource.com/chromium/src/+/0ffa5c7b260f5ac3290bad107d5b74faba967ceb which as one side effect made transparency be communicated correctly for this GIF situation, and therefore making the paint code correctly detect that it has to paint the background of the image because the foreground is not opaque. Will add a testcase before closing.
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb3ee6d5b69a35ec7d5c8d03a03edabbfe55e047 commit eb3ee6d5b69a35ec7d5c8d03a03edabbfe55e047 Author: Chris Harrelson <chrishtr@chromium.org> Date: Wed Oct 03 22:54:19 2018 [PE] Add test for painting background underneath a transparent GIF Bug: 887188 Change-Id: I6276bd2b97b4e39eb81fc52f6c8c934702f899c6 Reviewed-on: https://chromium-review.googlesource.com/c/1258052 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#596408} [add] https://crrev.com/eb3ee6d5b69a35ec7d5c8d03a03edabbfe55e047/third_party/WebKit/LayoutTests/images/transparent-gif-paint-background-expected.html [add] https://crrev.com/eb3ee6d5b69a35ec7d5c8d03a03edabbfe55e047/third_party/WebKit/LayoutTests/images/transparent-gif-paint-background.html
,
Oct 4
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vamshi.kommuri@chromium.org
, Sep 20