New issue
Advanced search Search tips

Issue 887185 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Chromevox does not save place when switching tabs if an unfocusable element has focus

Reported by daiv...@gmail.com, Sep 20

Issue description

Version: 70.0.3538.16
Reproduction Steps: 
# With Chromevox enabled, visit nfb.org and acb.org in separate tabs
# Move to the third heading on each tab by pressing search+h three times
# Switch between tabs and navigate by elements with search+right and left arrows
# Notice that Chromevox focus resets to the top of the tab
# Move to the first link after the third heading in each tab by pressing search+h 3 times and then tab once
# Switch between the two tabs and check position with search+right and left arrows
# Notice that focus remains on the chosen link on each tab

Expected: Chromevox remembers position when switching tabs

Actual: Chromevox forgets position if focus isn't a focusable element

 
Labels: -Pri-2 Pri-1
Owner: dtseng@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d3a3fd264aba286bb6dd15a88a022510064cf2f

commit 3d3a3fd264aba286bb6dd15a88a022510064cf2f
Author: David Tseng <dtseng@chromium.org>
Date: Thu Sep 27 19:34:31 2018

Fix tab switch recovery

ChromeVox's expectations with regard to tab switch recovery have changed. Namely:
- selection events appear to be fired unexpectedly on tabs at various points
- ChromeVox range is no longer over the root web area when a hit test result comes back even when we do want to recover

This change adjusts accordingly to TOT and adds tests for both tab switching and refresh recovery to ensure we don't regress again.

Bug:  887185 
Change-Id: I3081830457fb62c14456368a819b00765659a824
Reviewed-on: https://chromium-review.googlesource.com/1246366
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594815}
[modify] https://crrev.com/3d3a3fd264aba286bb6dd15a88a022510064cf2f/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/3d3a3fd264aba286bb6dd15a88a022510064cf2f/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

Status: Fixed (was: Assigned)

Sign in to add a comment