Flakiness Dashboard is broken for webkit_layout_tests |
||||||||||
Issue descriptionNavigate to https://test-results.appspot.com/dashboards/flakiness_dashboard.html (it seems to be loading slowly today but I'm not sure that's related to this. It takes a few minutes to display usable UI). Then select "webkit_layout_tests" from the pulldown and it's stuck in LOADING... There are errors on the console: builders.js:81 No master and builder found for webkit_tests builders.getBuilders @ builders.js:81 loader.js:120 Uncaught TypeError: Cannot read property 'forEach' of undefined at loader.Loader._loadResultsFiles (loader.js:120) at loader.Loader.load (loader.js:102) at flakiness_dashboard.js:1631 loader.js:227 Uncaught TypeError: Cannot read property 'length' of undefined at loader.Loader._haveResultsFilesLoaded (loader.js:227) at loader.Loader._handleResourceLoad (loader.js:214) at loader.Loader._handleResultsFileLoaded (loader.js:156) at loader.js:140 at base.js:45 at XMLHttpRequest.xhr.onreadystatechange (loader.js:54)
,
Sep 20
,
Sep 21
Raise priority
,
Sep 25
Issue 888663 has been merged into this issue.
,
Sep 25
,
Sep 26
martiniss would you be able to triage this? This is currently blocking my work... Is there any alternative to flakiness dashboard that people are using in the meantime?
,
Sep 26
I think sean should know more about what to do here. What are you trying to do? You can view individual results for layout tests if you need that.
,
Sep 26
Thanks! I have reports that a layout test is flakily timing out. I'd like to see whether the timeouts are due it to just being generally slow and occassionally crosses the timeout threshold or whether it clearly gets stuck sometimes. I also want to see if a related test is also timing out.
,
Sep 26
It looks like "webkit_layout_tests (with patch)" might be working: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=navigation-redirect
,
Sep 26
I see. Yeah, there probably isn't really a way to diagnose that apart from this page. I think there's an easy fix for this problem; let me try to make a CL.
,
Sep 26
Yeah, there's some specific code which is breaking because of the literal string "webkit_layout_tests". The with patch version is run on tryserver, so if the layout test is timing out on the CQ, you can diagnose that with the data you're able to look at.
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/d95a6bfff9dce81d189320a66f34a4c5f154065f commit d95a6bfff9dce81d189320a66f34a4c5f154065f Author: Stephen Martinis <martiniss@chromium.org> Date: Wed Sep 26 01:09:41 2018 test-results: Check for extra builders before loading There's a bug in code which was landed one year ago, which apparently never got noticed or exposed until now. Check if we have extra builders before trying to bind them. Bug: 887177 Change-Id: Idaa30405f352f71e90e01e85edfe3a3c5f4e9940 Reviewed-on: https://chromium-review.googlesource.com/1244290 Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#17882} [modify] https://crrev.com/d95a6bfff9dce81d189320a66f34a4c5f154065f/go/src/infra/appengine/test-results/frontend/static/dashboards/js/loader.js
,
Sep 26
Ok, the CL in #12 didn't fix this. There are several other conditions which still seem to break. sergiyb@, you added this code originally, and have TODOS assigned to you in the code. Can you fix this?
,
Sep 26
I've changed teams and don't support flakiness dashboard anymore. Shuotao's team should be able to find an owner for this.
,
Sep 26
I uploaded a second CL which I think actually fixes this. https://crrev.com/c/1246473
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/733e80f187b8c7ed02bbd41f1e51880bfddfe0e8 commit 733e80f187b8c7ed02bbd41f1e51880bfddfe0e8 Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Sep 27 19:04:00 2018 test results: Remove layout tests special casing Effectively reverts https://crrev.com/c/586720. It looks like webkit_tests doesn't get uploaded to the flakiness dashboard anymore, so this should be unneeded. Bug: 887177 Change-Id: I216950d014df6b121460583626a02913646a4e3d Reviewed-on: https://chromium-review.googlesource.com/1246473 Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#17920} [modify] https://crrev.com/733e80f187b8c7ed02bbd41f1e51880bfddfe0e8/go/src/infra/appengine/test-results/frontend/static/dashboards/js/loader.js [modify] https://crrev.com/733e80f187b8c7ed02bbd41f1e51880bfddfe0e8/go/src/infra/appengine/test-results/frontend/static/dashboards/js/ui.js [modify] https://crrev.com/733e80f187b8c7ed02bbd41f1e51880bfddfe0e8/go/src/infra/appengine/test-results/frontend/static/dashboards/js/flakiness_dashboard.js
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b12eb188ea77c6c499fc5b041fdf7a14139c5577 commit b12eb188ea77c6c499fc5b041fdf7a14139c5577 Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Sep 27 19:20:30 2018 test results: Fix typo in loader.js I forgot to add this to my last CL. TBR=zhangtiff Bug: 887177 Change-Id: Ia3d12e46fcc7a71723043fb49afb9c1123586e66 Reviewed-on: https://chromium-review.googlesource.com/1249339 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#17921} [modify] https://crrev.com/b12eb188ea77c6c499fc5b041fdf7a14139c5577/go/src/infra/appengine/test-results/frontend/static/dashboards/js/loader.js
,
Sep 27
This is fixed in prod. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by falken@chromium.org
, Sep 20