New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 887160 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Block false error thrown after forget device request due to ambiguous event listener

Project Member Reported by jordynass@chromium.org, Sep 20

Issue description

The settings-multidevice-setup-page listens for the event 'close' as a proxy for the password prompt being confirmed. However, the event type 'close' is ubiquitous to cr-dialog so it also fires when the forget device dialog is closed on the subpage, which causes the assertion "assert(this.featureToBeEnabledOnceAuthenticated_ !== null)" in SettingsMultidevicePageElement.onPasswordPromptDialogClose() to fail.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2d014a7e9148b0c455736957f1714932f5778b9

commit d2d014a7e9148b0c455736957f1714932f5778b9
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Thu Sep 20 19:42:10 2018

[CrOS MultiDevice] Block false Settings error from ambiguous listener.

The settings-multidevice-setup-page listens for the event 'close'
as a proxy for the password prompt being confirmed. However, the
event type 'close' is ubiquitous to cr-dialog so it also fires when
the forget device dialog is closed on the subpage, which causes the
assertion "assert(this.featureToBeEnabledOnceAuthenticated_ !== null)"
in SettingsMultidevicePageElement.onPasswordPromptDialogClose() to
fail.

This CL only calls onPasswordPromptDialogClose_ if the close event came
from the MultiDevice page's password prompt and stops the event's
propagation.

Bug:  887160 
Change-Id: I5740061c8f9e08ee5ba9e8d99862bcec6b0a6677
Reviewed-on: https://chromium-review.googlesource.com/1235321
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592908}
[modify] https://crrev.com/d2d014a7e9148b0c455736957f1714932f5778b9/chrome/browser/resources/settings/multidevice_page/multidevice_page.html
[modify] https://crrev.com/d2d014a7e9148b0c455736957f1714932f5778b9/chrome/browser/resources/settings/multidevice_page/multidevice_page.js
[modify] https://crrev.com/d2d014a7e9148b0c455736957f1714932f5778b9/chrome/test/data/webui/settings/multidevice_page_tests.js

Components: -UI>ProximityAuth UI>Multidevice
Status: Fixed (was: Started)

Sign in to add a comment