CrOS build system needs to support DLCs |
|||
Issue descriptionAdd ability to build a DLC. Design doc: https://docs.google.com/document/d/19aHLxvedBFNhlswciip-ZUntNgJ5L6nZ0Zm9VhSBDkE/edit?usp=sharing We can start with the modification of 1 ebuild and the modifications to build_image so it creates a DLC and its metadata on top of the base image.
,
Sep 28
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1eca34bc38e1885a4eab1bc3bc897704d7179df5 commit 1eca34bc38e1885a4eab1bc3bc897704d7179df5 Author: Colin Howes <chowes@google.com> Date: Mon Oct 08 15:14:42 2018 dlc.eclass: Add eclass to facilitate building DLC packages The DLC eclass can be inherited by DLC ebuilds in order to facilitate building and installing DLC images and metadata. BUG=chromium:887158 TEST=Tested with a simple test DLC. DLC images and metadata are generated as expected during build_packages when a dependency exists for that DLC. Change-Id: Iaf6477bb870cd7086c8043552ba1230ef6f57047 Reviewed-on: https://chromium-review.googlesource.com/c/1246302 Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> Reviewed-by: Colin Howes <chowes@google.com> Commit-Queue: Colin Howes <chowes@google.com> Tested-by: Colin Howes <chowes@google.com> Trybot-Ready: Colin Howes <chowes@google.com> [add] https://crrev.com/1eca34bc38e1885a4eab1bc3bc897704d7179df5/eclass/dlc.eclass
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/8fd9d735fdea790f7e238552bd892976bb5fe36d commit 8fd9d735fdea790f7e238552bd892976bb5fe36d Author: Colin Howes <chowes@google.com> Date: Mon Oct 08 17:54:47 2018 build_dlc: Specify image and metadata directories separately Change the API to allow the caller to specify separate image and metadata directories. This is useful when invoking build_dlc from an ebuild, since metadata is installed to the device whereas images are not. BUG=chromium:887158 TEST=Tested along with dlc.eclass on a simple DLC build Change-Id: I1c74a898fbdf1a4c97f794cc294208e81317bb64 Reviewed-on: https://chromium-review.googlesource.com/c/1252927 Commit-Queue: Colin Howes <chowes@google.com> Tested-by: Colin Howes <chowes@google.com> Trybot-Ready: Colin Howes <chowes@google.com> Reviewed-by: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by: Colin Howes <chowes@google.com> [modify] https://crrev.com/8fd9d735fdea790f7e238552bd892976bb5fe36d/scripts/build_dlc.py
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/d00e9dca44d878bd445bae383893e569870001b3 commit d00e9dca44d878bd445bae383893e569870001b3 Author: Colin Howes <chowes@google.com> Date: Mon Oct 08 19:52:18 2018 Revert "build_dlc: Specify image and metadata directories separately" This reverts commit 8fd9d735fdea790f7e238552bd892976bb5fe36d. Reason for revert: Breaks build_dlc_unittest Original change's description: > build_dlc: Specify image and metadata directories separately > > Change the API to allow the caller to specify separate image and > metadata directories. This is useful when invoking build_dlc from an > ebuild, since metadata is installed to the device whereas images are > not. > > BUG=chromium:887158 > TEST=Tested along with dlc.eclass on a simple DLC build > > Change-Id: I1c74a898fbdf1a4c97f794cc294208e81317bb64 > Reviewed-on: https://chromium-review.googlesource.com/c/1252927 > Commit-Queue: Colin Howes <chowes@google.com> > Tested-by: Colin Howes <chowes@google.com> > Trybot-Ready: Colin Howes <chowes@google.com> > Reviewed-by: Xiaochu Liu <xiaochu@chromium.org> > Reviewed-by: Colin Howes <chowes@google.com> Bug: chromium:887158 Change-Id: If4e6749bdabd946151a614153f291dacc46046fe Reviewed-on: https://chromium-review.googlesource.com/c/1268762 Reviewed-by: Nicolas Norvez <norvez@chromium.org> Commit-Queue: Nicolas Norvez <norvez@chromium.org> Tested-by: Nicolas Norvez <norvez@chromium.org> [modify] https://crrev.com/d00e9dca44d878bd445bae383893e569870001b3/scripts/build_dlc.py
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/fc6076842c5f0ee4ab4786344d4acceb197f6e47 commit fc6076842c5f0ee4ab4786344d4acceb197f6e47 Author: Colin Howes <chowes@google.com> Date: Fri Oct 12 22:18:27 2018 build_dlc: Specify image and metadata directories separately Change the API to allow the caller to specify separate image and metadata directories. This is useful when invoking build_dlc from an ebuild, since metadata is installed to the device whereas images are not. BUG=chromium:887158 TEST=Tested along with dlc.eclass on a simple DLC build Change-Id: I4b891e69309f2bfc2a3ba35c56ebdaab4a6ad9a9 Reviewed-on: https://chromium-review.googlesource.com/1269937 Commit-Ready: Colin Howes <chowes@google.com> Tested-by: Colin Howes <chowes@google.com> Reviewed-by: Colin Howes <chowes@google.com> Reviewed-by: Xiaochu Liu <xiaochu@chromium.org> [modify] https://crrev.com/fc6076842c5f0ee4ab4786344d4acceb197f6e47/scripts/build_dlc_unittest.py [modify] https://crrev.com/fc6076842c5f0ee4ab4786344d4acceb197f6e47/scripts/build_dlc.py
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/9d9577be528b124695438e4652890076a4b39b28 commit 9d9577be528b124695438e4652890076a4b39b28 Author: Colin Howes <chowes@google.com> Date: Fri Dec 14 03:28:21 2018 dlc_setup: Script to copy DLC to output directory Add a script that can be invoked from build_image in order to copy DLC images and metadata into the appropriate subfolders in the output directory. Metadata functions are currently just placeholders, since the format is still TBD. BUG=chromium:887158 TEST=Manual Change-Id: I5b732c38c8c5086e95c4333629378e8f7b4ffb17 Reviewed-on: https://chromium-review.googlesource.com/1252738 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Colin Howes <chowes@google.com> Reviewed-by: Nicolas Norvez <norvez@chromium.org> [add] https://crrev.com/9d9577be528b124695438e4652890076a4b39b28/scripts/dlc_setup.py [add] https://crrev.com/9d9577be528b124695438e4652890076a4b39b28/bin/dlc_setup
,
Dec 14
Support is mostly implemented, we just need to implement whatever is needed to integrate with GoldenEye's changes and add some hooks to build_image. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Sep 28