New issue
Advanced search Search tips

Issue 887150 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Cleanup all unnecessary "md_" prefixes from folder/file names

Project Member Reported by dpa...@chromium.org, Sep 20

Issue description

As part of the (multi-year) WebUI refresh to Material Design, the following folders/files have been added

chrome/browser/resources/webui/md_bookmarks/
chrome/browser/resources/webui/md_downloads/
chrome/browser/resources/webui/md_extensions/
chrome/browser/resources/webui/md_history/
chrome/browser/resources/webui/md_user_manager/

chrome/browser/ui/webui/md_bookmarks/
chrome/browser/ui/webui/md_downloads/
chrome/browser/ui/webui/settings/md_settings_* (5 files)

chrome/test/data/webui/md_bookmarks/
chrome/test/data/webui/md_downloads/
chrome/test/data/webui/md_history/
chrome/test/data/webui/md_user_manager/

chrome/app/md_extensions_strings.grdp


Benefits of removing

 - Left-overs: The prefixes made sense at the time, when both the MD and non-MD versions of various WebUI pages co-existed, which is no longer the case.
 - Less is better: Having smaller file/folder names reduces the amount of reading and typing one needs to do on a daily basis (opening files, searching on cs.chromium.org etc). It also reduces the need to explain the "md_" prefix to newer team members.
- Might help discourage/phase-out future usage of the "MD" terminology in crbug and CL descriptions. For example I still notice "MD Settings" in crbug and CL descriptions occasionally, as opposed to just "Settings" or "Settings WebUI".
 
I'll volunteer to remove these prefixes from md_extensions.  I'll be holding off on doing so for another couple weeks, because of the likelihood of merging changes back as part of the runtime host permissions project, but will land it after the dust settles a bit.
Cc: johntlee@chromium.org
Status: Started (was: Available)
Status: Available (was: Started)
This issue has been marked as started, but has no owner. Making available.
Owner: johntlee@google.com
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/457ebaaa3220f02c4b678506559705e043e67d66

commit 457ebaaa3220f02c4b678506559705e043e67d66
Author: John Lee <johntlee@chromium.org>
Date: Thu Jan 17 17:07:14 2019

WebUI: Rename md_bookmarks folders/files to bookmarks

Bug: 887150
Change-Id: I60427128df33ad54e3fd9f4cd41b691844001dc2
Reviewed-on: https://chromium-review.googlesource.com/c/1407494
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623725}
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/WATCHLISTS
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/BUILD.gn
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/bookmarks/bookmark_model_factory.cc
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/browser_resources.grd
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/extensions/extension_url_rewrite_browsertest.cc
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/BUILD.gn
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/BUILD.gn
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/OWNERS
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/README.md
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/actions.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/actions.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/api_listener.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/api_listener.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/app.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/app.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/bookmarks.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/command_manager.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/command_manager.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/constants.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/constants.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/debouncer.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/debouncer.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/dialog_focus_manager.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/dialog_focus_manager.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/dnd_manager.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/dnd_manager.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/edit_dialog.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/edit_dialog.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/folder_node.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/folder_node.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/images/folder.svg
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/images/folder_open.svg
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/item.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/item.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/list.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/list.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/mouse_focus_behavior.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/mouse_focus_behavior.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/reducers.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/reducers.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/router.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/router.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/shared_style.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/shared_vars.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/store.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/store.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/store_client.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/store_client.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/strings.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/toast_manager.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/toast_manager.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/toolbar.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/toolbar.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/types.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/util.html
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/bookmarks/util.js
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/resources/component_extension_resources.grd
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/ui/chrome_pages.cc
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/ui/webui/bookmarks/OWNERS
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/ui/webui/bookmarks/bookmarks_browsertest.cc
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/ui/webui/bookmarks/bookmarks_browsertest.h
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/ui/webui/bookmarks/bookmarks_message_handler.cc
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/ui/webui/bookmarks/bookmarks_message_handler.h
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/ui/webui/bookmarks/bookmarks_ui.cc
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/ui/webui/bookmarks/bookmarks_ui.h
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/BUILD.gn
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/BUILD.gn
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/.eslintrc.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/actions_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/app_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/bookmarks_browsertest.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/bookmarks_focus_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/command_manager_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/dnd_manager_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/edit_dialog_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/folder_node_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/item_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/list_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/policy_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/reducers_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/router_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/store_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/test_command_manager.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/test_store.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/test_timer_proxy.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/test_util.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/toast_manager_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/toolbar_test.js
[rename] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/bookmarks/util_test.js
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/chrome/test/data/webui/test_store.js
[modify] https://crrev.com/457ebaaa3220f02c4b678506559705e043e67d66/ui/webui/resources/js/cr/ui/store_client.js

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21215e1ee2f45a9600cd65a1058deda6f4fa3df3

commit 21215e1ee2f45a9600cd65a1058deda6f4fa3df3
Author: John Lee <johntlee@chromium.org>
Date: Fri Jan 18 01:40:30 2019

WebUI: Remove all md/material prefixes in Bookmarks code, including
renaming IDS_MD_BOOKMARKS_ and IDR_MD_BOOKMARKS_ IDs.

Bug: 887150
Change-Id: Icc96d5208af1daf72611c0645269b0e01b40471d
Reviewed-on: https://chromium-review.googlesource.com/c/1418312
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623948}
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/chrome/app/bookmarks_strings.grdp
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/chrome/browser/browser_resources.grd
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/chrome/browser/resources/bookmarks/README.md
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/chrome/browser/resources/bookmarks/types.js
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/chrome/browser/resources/component_extension_resources.grd
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/chrome/browser/ui/webui/bookmarks/bookmarks_browsertest.cc
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/chrome/browser/ui/webui/bookmarks/bookmarks_browsertest.h
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/chrome/browser/ui/webui/bookmarks/bookmarks_ui.cc
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/chrome/browser/ui/webui/bookmarks/bookmarks_ui.h
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/chrome/browser/ui/webui/page_not_available_for_guest/page_not_available_for_guest_ui.cc
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/chrome/test/data/webui/bookmarks/bookmarks_browsertest.js
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/chrome/test/data/webui/bookmarks/bookmarks_focus_test.js
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/testing/buildbot/filters/webui_polymer2_browser_tests.filter
[modify] https://crrev.com/21215e1ee2f45a9600cd65a1058deda6f4fa3df3/testing/buildbot/filters/webui_polymer2_interactive_ui_tests.filter

Comment 8 by johntlee@chromium.org, Jan 18 (5 days ago)

Owner: johntlee@chromium.org

Sign in to add a comment