New issue
Advanced search Search tips

Issue 887134 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

NetworkFileShares UI: Pop dialog automatically when opening settings

Project Member Reported by baileyberro@chromium.org, Sep 19

Issue description

When clicking "SMB Shares" from the add new services menu, the Add New Share dialog should open automatically, so that rather than the user having to click SMB Shares > Add New Share, when entering via the Files App, the dialog is immediately opened.
 
Owner: baileyberro@chromium.org
Status: Started (was: Available)
Labels: OS-Chrome
Components: Platform>Apps>FileManager
Labels: -M-71 M-70
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b858ada76fc9f9aa596204d2fc6a7f51f44d1b9c

commit b858ada76fc9f9aa596204d2fc6a7f51f44d1b9c
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Sep 25 00:33:46 2018

Open add share dialog automatically from Add Services

- When navigating to NetworkFileShares settings from the Add New Services
menu in Files App, the settings should open with the Add Share dialog open.
- When navigating to the NetworkFileShares settings from the settings app,
the dialog should not automatically open.

Bug:  chromium:887134 
Change-Id: Ibdc8226ff8b4c9c0695542f8045fd11d5d25818b
Reviewed-on: https://chromium-review.googlesource.com/1237259
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593773}
[modify] https://crrev.com/b858ada76fc9f9aa596204d2fc6a7f51f44d1b9c/chrome/browser/chromeos/smb_client/smb_provider.cc
[modify] https://crrev.com/b858ada76fc9f9aa596204d2fc6a7f51f44d1b9c/chrome/browser/resources/settings/downloads_page/BUILD.gn
[modify] https://crrev.com/b858ada76fc9f9aa596204d2fc6a7f51f44d1b9c/chrome/browser/resources/settings/downloads_page/smb_shares_page.html
[modify] https://crrev.com/b858ada76fc9f9aa596204d2fc6a7f51f44d1b9c/chrome/browser/resources/settings/downloads_page/smb_shares_page.js
[modify] https://crrev.com/b858ada76fc9f9aa596204d2fc6a7f51f44d1b9c/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/b858ada76fc9f9aa596204d2fc6a7f51f44d1b9c/chrome/common/webui_url_constants.h

Labels: Merge-Request-70
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 26

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 27

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6edb689a5bd56485b4d7c69969f77b77f4cfb741

commit 6edb689a5bd56485b4d7c69969f77b77f4cfb741
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Sep 27 17:57:34 2018

Open add share dialog automatically from Add Services

- When navigating to NetworkFileShares settings from the Add New Services
menu in Files App, the settings should open with the Add Share dialog open.
- When navigating to the NetworkFileShares settings from the settings app,
the dialog should not automatically open.

Bug:  chromium:887134 
Change-Id: Ibdc8226ff8b4c9c0695542f8045fd11d5d25818b
Reviewed-on: https://chromium-review.googlesource.com/1237259
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593773}(cherry picked from commit b858ada76fc9f9aa596204d2fc6a7f51f44d1b9c)
Reviewed-on: https://chromium-review.googlesource.com/1249828
Cr-Commit-Position: refs/branch-heads/3538@{#707}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/6edb689a5bd56485b4d7c69969f77b77f4cfb741/chrome/browser/chromeos/smb_client/smb_provider.cc
[modify] https://crrev.com/6edb689a5bd56485b4d7c69969f77b77f4cfb741/chrome/browser/resources/settings/downloads_page/BUILD.gn
[modify] https://crrev.com/6edb689a5bd56485b4d7c69969f77b77f4cfb741/chrome/browser/resources/settings/downloads_page/smb_shares_page.html
[modify] https://crrev.com/6edb689a5bd56485b4d7c69969f77b77f4cfb741/chrome/browser/resources/settings/downloads_page/smb_shares_page.js
[modify] https://crrev.com/6edb689a5bd56485b4d7c69969f77b77f4cfb741/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/6edb689a5bd56485b4d7c69969f77b77f4cfb741/chrome/common/webui_url_constants.h

Status: Fixed (was: Started)

Sign in to add a comment