New issue
Advanced search Search tips

Issue 887133 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

NetworkFileSharesUI: Add most recently used URL to dropdown

Project Member Reported by baileyberro@chromium.org, Sep 19

Issue description

Since it is very common that consumers use the same share over and over, we should automatically populate the last connected share in the Add Share Dialog
 
I think it should be in the drop down, and be the default selection (ie. be in the text box too).
Components: Platform>Apps>FileManager
Owner: jimmyxgong@chromium.org
Labels: OS-Chrome
Labels: -M-71 M-72
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41d82520fd4603048678f4e87cf391633e4a35cc

commit 41d82520fd4603048678f4e87cf391633e4a35cc
Author: Jimmy Gong <jimmyxgong@google.com>
Date: Wed Oct 31 22:17:25 2018

Add most recently used mount URL to File Share URL in SMB add dialog

- The text field for File Share URL will now initialize to the most
  recently used share path.

Bug:  chromium:887133 
Test: end to end
Change-Id: Ic59f7d34332b25c0e28832c6109060b849e838f2
Reviewed-on: https://chromium-review.googlesource.com/c/1300797
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604418}
[modify] https://crrev.com/41d82520fd4603048678f4e87cf391633e4a35cc/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/41d82520fd4603048678f4e87cf391633e4a35cc/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/41d82520fd4603048678f4e87cf391633e4a35cc/chrome/browser/resources/settings/downloads_page/smb_shares_page.html
[modify] https://crrev.com/41d82520fd4603048678f4e87cf391633e4a35cc/chrome/common/pref_names.cc
[modify] https://crrev.com/41d82520fd4603048678f4e87cf391633e4a35cc/chrome/common/pref_names.h
[modify] https://crrev.com/41d82520fd4603048678f4e87cf391633e4a35cc/chrome/test/data/webui/settings/smb_shares_page_tests.js
[modify] https://crrev.com/41d82520fd4603048678f4e87cf391633e4a35cc/ui/webui/resources/cr_components/chromeos/smb_shares/add_smb_share_dialog.js

Status: Fixed (was: Started)

Sign in to add a comment