NetworkFileShares UI: Fix name in Add New Services menu |
||||||||||
Issue descriptionUpdate the name from "Smb Shares" in the Files App's "Add New Services" menu. Still waiting on confirmation on UX whether it should be "File share" or "SMB file share"
,
Sep 21
,
Sep 24
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73ff03f5b59f7537a57658b70270091cafb18c44 commit 73ff03f5b59f7537a57658b70270091cafb18c44 Author: Bailey Berro <baileyberro@chromium.org> Date: Mon Sep 24 18:18:44 2018 change and localize smb file share menu option text - Changes the option displayed in the files app "add new services menu" from"SMB Shares" to "SMB file share" Bug: chromium:887132 Change-Id: I066e36e1ec992dce40971eced993b9aea5a0b7c8 Reviewed-on: https://chromium-review.googlesource.com/1239213 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#593602} [modify] https://crrev.com/73ff03f5b59f7537a57658b70270091cafb18c44/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/73ff03f5b59f7537a57658b70270091cafb18c44/chrome/browser/chromeos/smb_client/smb_provider.cc
,
Sep 27
,
Sep 28
,
Sep 28
This bug requires manual review: There is .grd file changes and we are only 17 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 1
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc6cabce8ec60e9313f5665691dd8724906d7743 commit cc6cabce8ec60e9313f5665691dd8724906d7743 Author: Zentaro Kavanagh <zentaro@chromium.org> Date: Tue Oct 02 16:36:47 2018 change and localize smb file share menu option text - Changes the option displayed in the files app "add new services menu" from"SMB Shares" to "SMB file share" TBR=baileyberro@chromium.org (cherry picked from commit 73ff03f5b59f7537a57658b70270091cafb18c44) Bug: chromium:887132 Change-Id: I066e36e1ec992dce40971eced993b9aea5a0b7c8 Reviewed-on: https://chromium-review.googlesource.com/1239213 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593602} Reviewed-on: https://chromium-review.googlesource.com/1257244 Cr-Commit-Position: refs/branch-heads/3538@{#817} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/cc6cabce8ec60e9313f5665691dd8724906d7743/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/cc6cabce8ec60e9313f5665691dd8724906d7743/chrome/browser/chromeos/smb_client/smb_provider.cc
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc6cabce8ec60e9313f5665691dd8724906d7743 Commit: cc6cabce8ec60e9313f5665691dd8724906d7743 Author: zentaro@chromium.org Commiter: zentaro@chromium.org Date: 2018-10-02 16:36:47 +0000 UTC change and localize smb file share menu option text - Changes the option displayed in the files app "add new services menu" from"SMB Shares" to "SMB file share" TBR=baileyberro@chromium.org (cherry picked from commit 73ff03f5b59f7537a57658b70270091cafb18c44) Bug: chromium:887132 Change-Id: I066e36e1ec992dce40971eced993b9aea5a0b7c8 Reviewed-on: https://chromium-review.googlesource.com/1239213 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593602} Reviewed-on: https://chromium-review.googlesource.com/1257244 Cr-Commit-Position: refs/branch-heads/3538@{#817} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 2
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by baileyberro@chromium.org
, Sep 21