New issue
Advanced search Search tips

Issue 887129 link

Starred by 1 user
Status: Fixed
Owner:
jamescook@chromium.org
Closed: Sep 20
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Extra Play Store icon on shelf with SingleProcessMash

Project Member Reported by jamescook@chromium.org, Sep 19 
chrome ToT r592578 on veyron_minnie

Add --enable-features=SingleProcessMash to /etc/chrome_dev.conf
Log in
Pin "Play Store" to shelf
Start "Play Store"

You'll see a blank icon in addition to the pinned icon. The extra icon is probably coming from ShelfWindowWatcher.
Screenshot 2018-09-19 at 2.42.47 PM.png
853 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9ca155ccc609a02f03ec61270ecc0a8a64b737c

commit f9ca155ccc609a02f03ec61270ecc0a8a64b737c
Author: James Cook <jamescook@chromium.org>
Date: Thu Sep 20 16:32:41 2018

Fix extra shelf icon for pinned ARC++ apps under SingleProcessMash

ArcAppWindowLauncherController was observing the wrong aura::Env for
window creation, so it wasn't calling AttachControllerToWindowIfNeeded
to set the correct ShelfID on the window.

Bug:  887129 
Test: pin Play Store icon, then tap on it
Change-Id: I2239a032962b783a50e562b822f021ef6e0a7511
Reviewed-on: https://chromium-review.googlesource.com/1235152
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592829}
[modify] https://crrev.com/f9ca155ccc609a02f03ec61270ecc0a8a64b737c/chrome/browser/ui/ash/launcher/DEPS
[modify] https://crrev.com/f9ca155ccc609a02f03ec61270ecc0a8a64b737c/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

Comment 2 by jamescook@chromium.org, Sep 20

Status: Fixed (was: Started)
►

Sign in to add a comment