New issue
Advanced search Search tips

Issue 887127 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

NetworkFileShares UI: Update Error Strings

Project Member Reported by baileyberro@chromium.org, Sep 19

Issue description

The error strings for the various SmbMountResult's should be updated to include more detail.
 
Owner: baileyberro@chromium.org
Components: Platform>Apps>FileManager
Update SMB1 error with more information.

Possibly try to track name resolution and distuinguish this case.
Owner: jimmyxgong@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a44b1caabf20abe59ed91c3f1067146681a804ff

commit a44b1caabf20abe59ed91c3f1067146681a804ff
Author: jimmy <jimmyxgong@chromium.org>
Date: Fri Oct 12 21:10:28 2018

Add more detailed error message for unsupported SMB mounts

- Adds a message to provide users with a more detailed error message
  when SMB mounting to a file server that doesn't support SMBv2 or later.

Bug:  chromium:887127 
Change-Id: I9e2ff3c278bb014c5538082ddcba42c8556ba8f2
Reviewed-on: https://chromium-review.googlesource.com/c/1274608
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599353}
[modify] https://crrev.com/a44b1caabf20abe59ed91c3f1067146681a804ff/chrome/app/settings_strings.grdp

Labels: Merge-Request-71
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 15

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: There is .grd file changes and we are only 49 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 Chrome OS.

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 16

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a95bef454fd9e63859519831e41f23d97bad952

commit 6a95bef454fd9e63859519831e41f23d97bad952
Author: jimmy <jimmyxgong@chromium.org>
Date: Tue Oct 16 22:40:10 2018

Add more detailed error message for unsupported SMB mounts

- Adds a message to provide users with a more detailed error message
  when SMB mounting to a file server that doesn't support SMBv2 or later.

Bug:  chromium:887127 
Change-Id: I9e2ff3c278bb014c5538082ddcba42c8556ba8f2
Reviewed-on: https://chromium-review.googlesource.com/c/1274608
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599353}(cherry picked from commit a44b1caabf20abe59ed91c3f1067146681a804ff)
Reviewed-on: https://chromium-review.googlesource.com/c/1285088
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#70}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/6a95bef454fd9e63859519831e41f23d97bad952/chrome/app/settings_strings.grdp

Status: Fixed (was: Started)
Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/6a95bef454fd9e63859519831e41f23d97bad952

Commit: 6a95bef454fd9e63859519831e41f23d97bad952
Author: jimmyxgong@chromium.org
Commiter: baileyberro@chromium.org
Date: 2018-10-16 22:40:10 +0000 UTC

Add more detailed error message for unsupported SMB mounts

- Adds a message to provide users with a more detailed error message
  when SMB mounting to a file server that doesn't support SMBv2 or later.

Bug:  chromium:887127 
Change-Id: I9e2ff3c278bb014c5538082ddcba42c8556ba8f2
Reviewed-on: https://chromium-review.googlesource.com/c/1274608
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599353}(cherry picked from commit a44b1caabf20abe59ed91c3f1067146681a804ff)
Reviewed-on: https://chromium-review.googlesource.com/c/1285088
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#70}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment