NetworkFileShares UI: Fix alignment of fields in add share dialog |
||||||||
Issue descriptionThe fields in the Add Share dialog should be extended to the width of the dialog. See UX Mocks
,
Sep 21
,
Sep 24
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65520fc3c69d77aa80eaca623afbb80b661ff1a0 commit 65520fc3c69d77aa80eaca623afbb80b661ff1a0 Author: Bailey Berro <baileyberro@chromium.org> Date: Wed Sep 26 23:18:19 2018 Make SMB add share dialog fields full width - Makes add dialog share fields stretch the full width of the dialog - Adds width styling mix-in to cr-searchable-drop-down - Updates add printer styling to be consistent after removing fixed width styling from cr-searchable-drop-down Bug: chromium:887111 Change-Id: Ibcb9c67b90cff9d0c5bf0c8cc058b6d218cb1f1a Reviewed-on: https://chromium-review.googlesource.com/1244614 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594516} [modify] https://crrev.com/65520fc3c69d77aa80eaca623afbb80b661ff1a0/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html [modify] https://crrev.com/65520fc3c69d77aa80eaca623afbb80b661ff1a0/ui/webui/resources/cr_elements/cr_searchable_drop_down/cr_searchable_drop_down.html
,
Sep 27
,
Sep 27
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19176ced2767a182a28086b64a6e56f752af79ff Commit: 19176ced2767a182a28086b64a6e56f752af79ff Author: baileyberro@chromium.org Commiter: zentaro@chromium.org Date: 2018-09-27 23:02:59 +0000 UTC Make SMB add share dialog fields full width - Makes add dialog share fields stretch the full width of the dialog - Adds width styling mix-in to cr-searchable-drop-down - Updates add printer styling to be consistent after removing fixed width styling from cr-searchable-drop-down Bug: chromium:887111 Change-Id: Ibcb9c67b90cff9d0c5bf0c8cc058b6d218cb1f1a Reviewed-on: https://chromium-review.googlesource.com/1244614 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#594516}(cherry picked from commit 65520fc3c69d77aa80eaca623afbb80b661ff1a0) Reviewed-on: https://chromium-review.googlesource.com/1249886 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#718} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19176ced2767a182a28086b64a6e56f752af79ff commit 19176ced2767a182a28086b64a6e56f752af79ff Author: Bailey Berro <baileyberro@chromium.org> Date: Thu Sep 27 23:02:59 2018 Make SMB add share dialog fields full width - Makes add dialog share fields stretch the full width of the dialog - Adds width styling mix-in to cr-searchable-drop-down - Updates add printer styling to be consistent after removing fixed width styling from cr-searchable-drop-down Bug: chromium:887111 Change-Id: Ibcb9c67b90cff9d0c5bf0c8cc058b6d218cb1f1a Reviewed-on: https://chromium-review.googlesource.com/1244614 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#594516}(cherry picked from commit 65520fc3c69d77aa80eaca623afbb80b661ff1a0) Reviewed-on: https://chromium-review.googlesource.com/1249886 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#718} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/19176ced2767a182a28086b64a6e56f752af79ff/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html [modify] https://crrev.com/19176ced2767a182a28086b64a6e56f752af79ff/ui/webui/resources/cr_elements/cr_searchable_drop_down/cr_searchable_drop_down.html
,
Sep 28
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by baileyberro@chromium.org
, Sep 19