New issue
Advanced search Search tips

Issue 887109 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove default_factory from URLLoaderFactoryBundle

Project Member Reported by jam@chromium.org, Sep 19

Issue description

The URLLoaderFactoryBundle mojo struct has:
  // The default factory to be used when no others apply.
  network.mojom.URLLoaderFactory default_factory;

  // A mapping from URL scheme to factory interface.
  map<string, network.mojom.URLLoaderFactory> factories;

We can simplify it by having only a map. The reason a default_factory exists is because then we can send one mojo pipe for all the schemes handled by the network process, when default_factory points to it. In previous brainstormings when this was added, Ken had suggested having a map keyed by array<string>. That way we'd still send just one pipe to the network process. This would simplify the renderer side a little, and add consistency as well as to how it looks up factories.
 
Would it mean we might be having an entry keyed by, say, <http, https, ws, ...> etc?
Right
Cc: -roc...@chromium.org rockot@google.com
Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Sign in to add a comment