Remove default_factory from URLLoaderFactoryBundle |
|||
Issue descriptionThe URLLoaderFactoryBundle mojo struct has: // The default factory to be used when no others apply. network.mojom.URLLoaderFactory default_factory; // A mapping from URL scheme to factory interface. map<string, network.mojom.URLLoaderFactory> factories; We can simplify it by having only a map. The reason a default_factory exists is because then we can send one mojo pipe for all the schemes handled by the network process, when default_factory points to it. In previous brainstormings when this was added, Ken had suggested having a map keyed by array<string>. That way we'd still send just one pipe to the network process. This would simplify the renderer side a little, and add consistency as well as to how it looks up factories.
,
Sep 20
Right
,
Oct 17
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6e87a44866c4860471163fc9fe217927bdb5a22 commit f6e87a44866c4860471163fc9fe217927bdb5a22 Author: Kinuko Yasuda <kinuko@chromium.org> Date: Fri Dec 21 08:15:27 2018 Cleanup: deprecate URLLoaderFactory::SetDefaultFactory() The method's not really needed (and in AppCache cases used wrongly after crrev.com/c/1371310) so removing it. Bug: 887109 Change-Id: I5dfc7bfe8739178f951f96de221ab97d63c5d0cc Reviewed-on: https://chromium-review.googlesource.com/c/1388131 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#618481} [modify] https://crrev.com/f6e87a44866c4860471163fc9fe217927bdb5a22/content/browser/worker_host/worker_script_fetch_initiator.cc [modify] https://crrev.com/f6e87a44866c4860471163fc9fe217927bdb5a22/content/common/url_loader_factory_bundle.cc [modify] https://crrev.com/f6e87a44866c4860471163fc9fe217927bdb5a22/content/common/url_loader_factory_bundle.h [modify] https://crrev.com/f6e87a44866c4860471163fc9fe217927bdb5a22/content/renderer/render_frame_impl.cc [modify] https://crrev.com/f6e87a44866c4860471163fc9fe217927bdb5a22/content/renderer/render_frame_impl.h [modify] https://crrev.com/f6e87a44866c4860471163fc9fe217927bdb5a22/content/renderer/renderer_webapplicationcachehost_impl.cc
,
Jan 11
Available, but no owner or component? Please find a component, as no one will ever find this without one. |
|||
►
Sign in to add a comment |
|||
Comment 1 by kinuko@chromium.org
, Sep 20