Add integration test for chrome client auth with network service |
|||
Issue descriptionAs per discussion about issue 843384 : https://bugs.chromium.org/p/chromium/issues/detail?id=843384 rsleevi@ pointed out that integration test for chrome client auth with network service would be nice. It would require a custom ContentBrowserClient.
,
Oct 17
There is actually one test, SSLUITest.TestBrowserUseClientCertStore, which uses the ProfileIOData::set_client_cert_store_factory_for_testing method. Testing signing failures and continuing with no cert should also be possible this way. I could do that since I'm already touching this code in another CL. Doesn't seem like there's a clean way to test cancelling at that level though.
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b272d3c96a7a595f6edd9a0f52febd1343c88f98 commit b272d3c96a7a595f6edd9a0f52febd1343c88f98 Author: Matt Mueller <mattm@chromium.org> Date: Tue Oct 23 00:41:17 2018 Add more browser_tests for client auth: failed signing and continue without cert Bug: 887095 Change-Id: I5556c05c6d8444ffb0a6ebec2ef46396e857fed4 Reviewed-on: https://chromium-review.googlesource.com/c/1286862 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#601804} [modify] https://crrev.com/b272d3c96a7a595f6edd9a0f52febd1343c88f98/chrome/browser/ssl/ssl_browsertest.cc [modify] https://crrev.com/b272d3c96a7a595f6edd9a0f52febd1343c88f98/net/ssl/client_cert_identity_test_util.cc [modify] https://crrev.com/b272d3c96a7a595f6edd9a0f52febd1343c88f98/net/ssl/client_cert_identity_test_util.h [modify] https://crrev.com/b272d3c96a7a595f6edd9a0f52febd1343c88f98/net/ssl/test_ssl_private_key.cc [modify] https://crrev.com/b272d3c96a7a595f6edd9a0f52febd1343c88f98/net/ssl/test_ssl_private_key.h
,
Dec 14
Matt: Fixed?
,
Dec 14
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dougt@chromium.org
, Sep 25