New issue
Advanced search Search tips

Issue 887081 link

Starred by 1 user
Status: Fixed
Owner:
zhangtiff@chromium.org
Closed: Oct 6
Cc:
dgarr...@chromium.org
seanmccullough@chromium.org
jclinton@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task

Blocking:
issue 887079



Sign in to add a comment

Remove ChromeOS sheriff-o-matic UI

Project Member Reported by jclinton@chromium.org, Sep 19 
Hi there. As we discussed a few quarters ago, we're going to shut down the SoM ChromeOS integration. Please use this bug to track removing ChromeOS from the SoM UI. I have other bugs tracking shutting down the ChromeOS-side of the integration.

This is—in a round-about-way—blocking our Swarming migration and thus migration off of Buildbot.

Comment 1 by zhangtiff@chromium.org, Sep 21

Labels: Milestone-CrOS
Thanks for filing this. Is action expeced of Sheriffing team here or will Chrome OS handle the removal?

Comment 2 by jclinton@chromium.org, Sep 23 

We need the sheriff-o-matic team to remove ChromeOS from the UI entirely. We will handle the rest.

Comment 3 by zhangtiff@chromium.org, Sep 24

Owner: zhangtiff@chromium.org
Alright, thanks for clarifying. I'll remove Chrome OS code from SoM's UI.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/374b3b749ab79f80d875456171e3760d546632db

commit 374b3b749ab79f80d875456171e3760d546632db
Author: Tiff Zhang <zhangtiff@google.com>
Date: Mon Oct 01 20:46:55 2018

SoM: Remove some ChromeOS specific logic.

Bug:  887081 
Change-Id: Iea3077f72c8e5e013f51a9be27a98fa988147670
Reviewed-on: https://chromium-review.googlesource.com/c/1241422
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17975}
[delete] https://crrev.com/d5a03fe26fe7fdf9f3d73cabd870657aeac07173/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-tree-behavior.html
[modify] https://crrev.com/374b3b749ab79f80d875456171e3760d546632db/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.js
[modify] https://crrev.com/374b3b749ab79f80d875456171e3760d546632db/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-build-failure/som-extension-build-failure.js
[modify] https://crrev.com/374b3b749ab79f80d875456171e3760d546632db/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-build-failure/som-extension-build-failure.html
[modify] https://crrev.com/374b3b749ab79f80d875456171e3760d546632db/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.js
[delete] https://crrev.com/d5a03fe26fe7fdf9f3d73cabd870657aeac07173/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-extension-cros-failure-test.html
[modify] https://crrev.com/374b3b749ab79f80d875456171e3760d546632db/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.html
[modify] https://crrev.com/374b3b749ab79f80d875456171e3760d546632db/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.js
[modify] https://crrev.com/374b3b749ab79f80d875456171e3760d546632db/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-alert-view-test.html
[modify] https://crrev.com/374b3b749ab79f80d875456171e3760d546632db/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.html
[delete] https://crrev.com/d5a03fe26fe7fdf9f3d73cabd870657aeac07173/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-cros-failure/som-extension-cros-failure.html
[delete] https://crrev.com/d5a03fe26fe7fdf9f3d73cabd870657aeac07173/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-cros-failure/som-extension-cros-failure.js
[modify] https://crrev.com/374b3b749ab79f80d875456171e3760d546632db/go/src/infra/appengine/sheriff-o-matic/som/handler/alerts.go
[modify] https://crrev.com/374b3b749ab79f80d875456171e3760d546632db/go/src/infra/appengine/sheriff-o-matic/frontend/test/index.html

Comment 5 by zhangtiff@chromium.org, Oct 6 

The Chrome OS UI should be removed from SoM.

Comment 6 by zhangtiff@chromium.org, Oct 6

Status: Fixed (was: Untriaged)
►

Sign in to add a comment