Flaky test: paint/invalidation/svg/image-animation-with-zoom.html Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=400c56fb5a6b8810 Test output log: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/24392 Culprit (74.4% confidence): https://chromium-review.googlesource.com/q/Id97f574f12deffbfe28e943a7735823be1533db9 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKLAWNocm9taXVtLndlYmtpdC9XZWJLaXQgTGludXggVHJ1c3R5IExlYWsvMjQzOTIvd2Via2l0X2xheW91dF90ZXN0cy9jR0ZwYm5RdmFXNTJZV3hwWkdGMGFXOXVMM04yWnk5cGJXRm5aUzFoYm1sdFlYUnBiMjR0ZDJsMGFDMTZiMjl0TG1oMGJXdz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20paint/invalidation/svg/image-animation-with-zoom.html&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKLAWNocm9taXVtLndlYmtpdC9XZWJLaXQgTGludXggVHJ1c3R5IExlYWsvMjQzOTIvd2Via2l0X2xheW91dF90ZXN0cy9jR0ZwYm5RdmFXNTJZV3hwWkdGMGFXOXVMM04yWnk5cGJXRm5aUzFoYm1sdFlYUnBiMjR0ZDJsMGFDMTZiMjl0TG1oMGJXdz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA
Revert in pipe, crrev.com/c/1243575. PTAL
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/510f673e7265b76cab3baa203879bebd2090e0c2 commit 510f673e7265b76cab3baa203879bebd2090e0c2 Author: Peter Boström <pbos@chromium.org> Date: Tue Sep 25 19:29:03 2018 Revert "bitmap.getColor can be expensive (unmpremul, etc.), so don't call if not needed" This reverts commit f52ee5d6e07ce2f81104bd55b495332b74f2455a. Reason for revert: FindIt likely root cause for paint/invalidation/svg/image-animation-with-zoom.html flakes. Original change's description: > bitmap.getColor can be expensive (unmpremul, etc.), so don't call if not needed > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Id97f574f12deffbfe28e943a7735823be1533db9 > Reviewed-on: https://chromium-review.googlesource.com/1233941 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Mike Reed <reed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592508} TBR=fmalita@chromium.org,reed@chromium.org,mtklein@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Bug: chromium:887076 Change-Id: I0aacc1a0d27bc2de676da2cfe7214ebb7cb5ba8c Reviewed-on: https://chromium-review.googlesource.com/1243575 Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#594054} [modify] https://crrev.com/510f673e7265b76cab3baa203879bebd2090e0c2/third_party/blink/renderer/platform/graphics/paint/drawing_display_item.cc [modify] https://crrev.com/510f673e7265b76cab3baa203879bebd2090e0c2/third_party/blink/renderer/platform/graphics/paint/raster_invalidation_tracking.cc
Comment 1 by pbos@chromium.org
, Sep 25Status: Assigned (was: Untriaged)