New issue
Advanced search Search tips

Issue 887071 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
M71



Sign in to add a comment

[Print preview refresh] Change padding in Advanced settings

Project Member Reported by namratakannan@chromium.org, Sep 19

Issue description

Saw this on Chrome in the new Canary build 71.0.3556.0

The padding between the Paper size settings and Fewer settings should be 16px
 
Padding issues in More settings.png
704 KB View Download
Cc: nyerramilli@chromium.org rbasuvula@chromium.org rbpotter@chromium.org
 Issue 886581  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/569651fe903bf5b1a9e6ebf721541c2a54fb5a28

commit 569651fe903bf5b1a9e6ebf721541c2a54fb5a28
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Sep 20 22:43:26 2018

Print Preview: Adjust more settings padding and set links actionable

Fixing 2 bugs:
(1) When "More settings" is expanded, margin should be 16px
(2) Make links actionable so hand pointer shows up

Bug:  887071 ,  887228 
Change-Id: Iccb185f7e75e6a6fd87eac45b9b0a9f21dae15ca
Reviewed-on: https://chromium-review.googlesource.com/1236501
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592979}
[modify] https://crrev.com/569651fe903bf5b1a9e6ebf721541c2a54fb5a28/chrome/browser/resources/print_preview/new/link_container.html
[modify] https://crrev.com/569651fe903bf5b1a9e6ebf721541c2a54fb5a28/chrome/browser/resources/print_preview/new/more_settings.html
[modify] https://crrev.com/569651fe903bf5b1a9e6ebf721541c2a54fb5a28/chrome/browser/resources/print_preview/new/more_settings.js

Cc: namratakannan@chromium.org
Status: Fixed (was: Available)
Should be fixed, please verify and re-open if not.
Verified

Sign in to add a comment