Issue metadata
Sign in to add a comment
|
DevTool's device emulator doesn't resize the webpage but crops it |
||||||||||||||||||||||
Issue descriptionI pinpointed the problem to this revision(432553b5cb40): https://chromium.googlesource.com/chromium/src/+/432553b5cb40dde1ae7ac1817dc7e2deecbf8e4e Its parent revision (d91dacc021d) is fine. OS: MacOS, Linux What steps will reproduce the problem? (1) Open a new tab, navigate to a website (2) Launch DevTools (3) Enable mobile device emulation What is the expected result? > The webpage should resize according to the height and width of the emulated device screen What happens instead? > The webpage is not resized. I pinpointed the problem to this revision(432553b5cb40): https://chromium.googlesource.com/chromium/src/+/432553b5cb40dde1ae7ac1817dc7e2deecbf8e4e Its parent revision (d91dacc021d) is fine. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Sep 19
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb643a6b869cf13fc8a00a7c259073925c531434 commit eb643a6b869cf13fc8a00a7c259073925c531434 Author: David Bokan <bokan@chromium.org> Date: Mon Sep 24 14:58:14 2018 Revert "Improve rotation check on viewport resize" This reverts commit 432553b5cb40dde1ae7ac1817dc7e2deecbf8e4e. Reason for revert: width == height isn't enough since the system bar affects only height. Broke 887064, 887330, 887899 Original change's description: > Improve rotation check on viewport resize > > Since rotation used to be supported only on Android, where windows can't > be resized, we made the assumption that if the width changes it must be > a rotation. > > This changes in ChromeOS where entering tablet mode enables rotation but > also resizes the window (when entering tablet mode). This caused > inappropriate rotation anchoring. > > The underlying issue has been fixed in other patches linked to this bug, > the rotation trigger should be improved to check that the width and > height are swapped. > > Bug: 831473 > Change-Id: I0acd39d16319d8cb7819faac4c4ce54b6f7a2e46 > Reviewed-on: https://chromium-review.googlesource.com/1224711 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591430} TBR=bokan@chromium.org,dtapuska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831473 ,887899, 887064 , 887330 Change-Id: Ib0f3cad366a80506effc62fcc352e1c75f2fcd55 Reviewed-on: https://chromium-review.googlesource.com/1239726 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593536} [modify] https://crrev.com/eb643a6b869cf13fc8a00a7c259073925c531434/third_party/blink/renderer/core/exported/web_view_impl.cc [modify] https://crrev.com/eb643a6b869cf13fc8a00a7c259073925c531434/third_party/blink/renderer/core/frame/rotation_viewport_anchor_test.cc [modify] https://crrev.com/eb643a6b869cf13fc8a00a7c259073925c531434/third_party/blink/renderer/core/html/image_document.h [modify] https://crrev.com/eb643a6b869cf13fc8a00a7c259073925c531434/third_party/blink/renderer/core/html/image_document_test.cc
,
Oct 2
The CL in question was reverted. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by hhli@chromium.org
, Sep 19