password_manager::AffiliationFetchThrottler currently uses net::NetworkChangeNotifier to be notified of network connection changes. It should be converted to use NetworkConnectionTracker, which will work when the network service is enabled.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95efac15123563d3a05e19feb75c676bb7634eef commit 95efac15123563d3a05e19feb75c676bb7634eef Author: Robbie McElrath <rmcelrath@chromium.org> Date: Thu Sep 27 18:12:37 2018 Migrate password_manager::AffiliationFetchThrottler to NetworkConnectionTracker This migrates password_manager::AffiliationFetchThrottler from NetworkChangeManager to NetworkConnectionTracker, which works with the network service enabled. Bug: 887058 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I04c2529e24ea0bf85ebb0646127ded2b594306c2 Reviewed-on: https://chromium-review.googlesource.com/1239359 Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#594783} [modify] https://crrev.com/95efac15123563d3a05e19feb75c676bb7634eef/chrome/browser/password_manager/password_store_factory.cc [modify] https://crrev.com/95efac15123563d3a05e19feb75c676bb7634eef/components/password_manager/core/browser/android_affiliation/affiliation_backend.cc [modify] https://crrev.com/95efac15123563d3a05e19feb75c676bb7634eef/components/password_manager/core/browser/android_affiliation/affiliation_backend.h [modify] https://crrev.com/95efac15123563d3a05e19feb75c676bb7634eef/components/password_manager/core/browser/android_affiliation/affiliation_backend_unittest.cc [modify] https://crrev.com/95efac15123563d3a05e19feb75c676bb7634eef/components/password_manager/core/browser/android_affiliation/affiliation_fetch_throttler.cc [modify] https://crrev.com/95efac15123563d3a05e19feb75c676bb7634eef/components/password_manager/core/browser/android_affiliation/affiliation_fetch_throttler.h [modify] https://crrev.com/95efac15123563d3a05e19feb75c676bb7634eef/components/password_manager/core/browser/android_affiliation/affiliation_fetch_throttler_unittest.cc [modify] https://crrev.com/95efac15123563d3a05e19feb75c676bb7634eef/components/password_manager/core/browser/android_affiliation/affiliation_service.cc [modify] https://crrev.com/95efac15123563d3a05e19feb75c676bb7634eef/components/password_manager/core/browser/android_affiliation/affiliation_service.h [modify] https://crrev.com/95efac15123563d3a05e19feb75c676bb7634eef/components/password_manager/core/browser/android_affiliation/affiliation_service_unittest.cc [modify] https://crrev.com/95efac15123563d3a05e19feb75c676bb7634eef/components/password_manager/core/browser/password_store_factory_util.cc [modify] https://crrev.com/95efac15123563d3a05e19feb75c676bb7634eef/components/password_manager/core/browser/password_store_factory_util.h [modify] https://crrev.com/95efac15123563d3a05e19feb75c676bb7634eef/ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc [modify] https://crrev.com/95efac15123563d3a05e19feb75c676bb7634eef/ios/web_view/internal/passwords/web_view_password_store_factory.mm
Comment 1 by rmcelrath@chromium.org
, Sep 21Status: Started (was: Available)