New issue
Advanced search Search tips

Issue 887057 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 821009



Sign in to add a comment

Migrate ReadingListDownloadService to NetworkConnectionTracker

Project Member Reported by rmcelrath@chromium.org, Sep 19

Issue description

ReadingListDownloadService currently uses net::NetworkChangeNotifier to be notified of network connection changes. It should be converted to use NetworkConnectionTracker, which will work when the network service is enabled.
 
Owner: rmcelrath@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db25835d3a1ab70b0af1f4dcc22aa7731e05a12a

commit db25835d3a1ab70b0af1f4dcc22aa7731e05a12a
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Wed Sep 26 19:14:46 2018

Migrate ReadingListDownloadService to NetworkConnectionTracker

This migrates ReadingListDownloadService from NetworkChangeNotifier to
NetworkConnectionTracker, which works with the network service enabled.

Bug:  887057 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo
Change-Id: Ic86d3bca9b77a53f97e9039fa35369a8fa9968b1
Reviewed-on: https://chromium-review.googlesource.com/1239339
Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594420}
[modify] https://crrev.com/db25835d3a1ab70b0af1f4dcc22aa7731e05a12a/ios/chrome/browser/reading_list/reading_list_download_service.cc
[modify] https://crrev.com/db25835d3a1ab70b0af1f4dcc22aa7731e05a12a/ios/chrome/browser/reading_list/reading_list_download_service.h
[modify] https://crrev.com/db25835d3a1ab70b0af1f4dcc22aa7731e05a12a/ios/chrome/test/testing_application_context.h
[modify] https://crrev.com/db25835d3a1ab70b0af1f4dcc22aa7731e05a12a/ios/chrome/test/testing_application_context.mm
[modify] https://crrev.com/db25835d3a1ab70b0af1f4dcc22aa7731e05a12a/services/network/public/cpp/network_connection_tracker.cc
[modify] https://crrev.com/db25835d3a1ab70b0af1f4dcc22aa7731e05a12a/services/network/public/cpp/network_connection_tracker.h

Status: Fixed (was: Started)

Sign in to add a comment