New issue
Advanced search Search tips

Issue 887051 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 613210
issue 836992
issue 878914



Sign in to add a comment

Mash: Render browser frame in browser process

Project Member Reported by est...@chromium.org, Sep 19

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b050fed7f8d9b90d4a066d796046faf14eab44c

commit 1b050fed7f8d9b90d4a066d796046faf14eab44c
Author: Evan Stade <estade@chromium.org>
Date: Fri Sep 21 21:17:17 2018

Move Ash caption buttons to //ash/public/cpp

1. Remove AshFrameSizeButton dependency on PhantomWindowController
   via a new interface. For Mash Chrome browser frames, this will
   be implemented via Mojo (for now, that's a TODO).

2. Add ash::TabletMode utility to //ash/public/cpp, which allows
   code in //ash/public/cpp to get the status of tablet mode from
   any process (each process has to provide a callback).

3. Move the files from private Ash to the new directory.

Bug:  887051 

Change-Id: Ib790a89fae89f02b92b36e1b165d59c9e28b59f7
Reviewed-on: https://chromium-review.googlesource.com/1228978
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593336}
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/BUILD.gn
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/ash_strings.grd
[add] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/ash_frame_caption_controller.cc
[add] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/ash_frame_caption_controller.h
[delete] https://crrev.com/c5e3dd0a12b8e8824edd26be7b54bf7c748deb6a/ash/frame/caption_buttons/frame_back_button.h
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/caption_buttons/frame_caption_button_unittest.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/caption_buttons/frame_size_button_unittest.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/custom_frame_header.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/custom_frame_header.h
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/default_frame_header.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/default_frame_header_unittest.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/detached_title_area_renderer.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/frame_header.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/frame_header.h
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/header_view.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/header_view.h
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/non_client_frame_view_ash.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/non_client_frame_view_ash.h
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/non_client_frame_view_ash_unittest.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/wide_frame_view.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/frame/wide_frame_view.h
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/BUILD.gn
[rename] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/caption_buttons/caption_button_model.h
[rename] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/caption_buttons/caption_button_types.h
[rename] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/caption_buttons/frame_back_button.cc
[add] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/caption_buttons/frame_back_button.h
[rename] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/caption_buttons/frame_caption_button.cc
[rename] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/caption_buttons/frame_caption_button.h
[rename] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/caption_buttons/frame_caption_button_container_view.cc
[rename] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/caption_buttons/frame_caption_button_container_view.h
[add] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/caption_buttons/frame_caption_delegate.h
[rename] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/caption_buttons/frame_size_button.cc
[rename] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/caption_buttons/frame_size_button.h
[rename] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/caption_buttons/frame_size_button_delegate.h
[rename] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/gesture_action_type.h
[add] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/tablet_mode.cc
[add] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/public/cpp/tablet_mode.h
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/system/unified/user_chooser_view.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/touch/touch_uma.h
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/wm/tablet_mode/tablet_mode_controller.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ash/wm/workspace/phantom_window_controller.h
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/chrome/browser/ui/ash/tablet_mode_client.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/components/exo/client_controlled_shell_surface_unittest.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/components/exo/wayland/server.cc
[modify] https://crrev.com/1b050fed7f8d9b90d4a066d796046faf14eab44c/ui/strings/ui_strings.grd

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b099f9d8e43c6e72e165b62816976d208870030

commit 4b099f9d8e43c6e72e165b62816976d208870030
Author: Evan Stade <estade@chromium.org>
Date: Thu Sep 27 16:30:19 2018

Mash: make Chrome responsible for drawing browser window frame

1. Implement Mojo api for snapping (FrameCaptionDelegate)
2. Move CustomFrameHeader to //chrome, rename to BrowserFrameHeaderAsh
3. Share more code between Mash and classic Ash in
   BrowserNonClientFrameViewAsh
4. Move FrameHeader to //ash/public, along with some utilities and
   vector icons
5. Delete some immersive-related code. The mash reveal widget and
   DetachedTitleAreaRenderer are no longer needed.
6. Remove some ash window properties that are no longer necessary

TODO:
1. remove old browser theme related code, including BrowserImageRegistrar
2. add handling for double tap/double click on browser window caption
   (to maximize). Also enable the context menu.
3. add handling for browser window dragging

Bug:  887051 
Change-Id: Ibc05728f6f91c4b94673431a8b97b7c79116d0eb
Reviewed-on: https://chromium-review.googlesource.com/1241833
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594747}
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/BUILD.gn
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/frame/ash_frame_caption_controller.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/frame/ash_frame_caption_controller.h
[delete] https://crrev.com/3e400a746ec659116c6f381fadbf5f4938131475/ash/frame/custom_frame_header.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/frame/default_frame_header_unittest.cc
[delete] https://crrev.com/3e400a746ec659116c6f381fadbf5f4938131475/ash/frame/detached_title_area_renderer.cc
[delete] https://crrev.com/3e400a746ec659116c6f381fadbf5f4938131475/ash/frame/detached_title_area_renderer.h
[delete] https://crrev.com/3e400a746ec659116c6f381fadbf5f4938131475/ash/frame/frame_header_util.cc
[delete] https://crrev.com/3e400a746ec659116c6f381fadbf5f4938131475/ash/frame/frame_header_util.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/frame/header_view.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/frame/header_view.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/frame/non_client_frame_view_ash.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/frame/non_client_frame_view_ash.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/frame/non_client_frame_view_ash_unittest.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/BUILD.gn
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/ash_constants.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/caption_buttons/frame_caption_button_container_view.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/caption_buttons/frame_caption_button_container_view.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/caption_buttons/frame_caption_delegate.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/caption_buttons/frame_size_button.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/caption_buttons/frame_size_button_delegate.h
[rename] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/default_frame_header.cc
[rename] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/default_frame_header.h
[rename] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/frame_header.cc
[rename] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/frame_header.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/frame_utils.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/frame_utils.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/mus_property_mirror_ash.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/vector_icons/BUILD.gn
[rename] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/vector_icons/window_control_back.icon
[rename] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/vector_icons/window_control_dezoom.icon
[rename] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/vector_icons/window_control_menu.icon
[rename] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/vector_icons/window_control_zoom.icon
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/cpp/window_properties.h
[delete] https://crrev.com/3e400a746ec659116c6f381fadbf5f4938131475/ash/public/cpp/window_style.cc
[delete] https://crrev.com/3e400a746ec659116c6f381fadbf5f4938131475/ash/public/cpp/window_style.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/interfaces/BUILD.gn
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/interfaces/ash_window_manager.mojom
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/public/interfaces/window_properties.mojom
[delete] https://crrev.com/3e400a746ec659116c6f381fadbf5f4938131475/ash/public/interfaces/window_style.mojom
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/resources/vector_icons/BUILD.gn
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/wm/non_client_frame_controller.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/wm/property_util.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/wm/property_util.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/wm/top_level_window_factory.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/ws/ash_window_manager.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/ash/ws/ash_window_manager.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/chrome/browser/ui/views/frame/browser_frame_header_ash.cc
[rename] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/chrome/browser/ui/views/frame/browser_frame_header_ash.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/chrome/browser/ui/views/frame/browser_frame_mash.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/chrome/browser/ui/views/frame/browser_view_layout_unittest.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/chrome/browser/ui/views/frame/immersive_mode_controller.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/chrome/browser/ui/views/frame/immersive_mode_controller_stub.cc
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/chrome/browser/ui/views/frame/immersive_mode_controller_stub.h
[modify] https://crrev.com/4b099f9d8e43c6e72e165b62816976d208870030/components/exo/client_controlled_shell_surface.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0b10e584b273bbff27a070cba84c3b6242af2bd

commit b0b10e584b273bbff27a070cba84c3b6242af2bd
Author: Evan Stade <estade@chromium.org>
Date: Wed Oct 03 21:00:21 2018

Ash: Remove ClientImageRegistry

Interface was added for browser frame theme images, but it's no longer needed.

Bug:  887051 
Change-Id: Ic015e41da421b81b5174f55b49c0f2b025dd10c6
Reviewed-on: https://chromium-review.googlesource.com/c/1257808
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596356}
[modify] https://crrev.com/b0b10e584b273bbff27a070cba84c3b6242af2bd/ash/BUILD.gn
[delete] https://crrev.com/8f88d5d873deb1ce9438dfafa49865097da31e5b/ash/client_image_registry.cc
[delete] https://crrev.com/8f88d5d873deb1ce9438dfafa49865097da31e5b/ash/client_image_registry.h
[modify] https://crrev.com/b0b10e584b273bbff27a070cba84c3b6242af2bd/ash/frame/header_view.cc
[modify] https://crrev.com/b0b10e584b273bbff27a070cba84c3b6242af2bd/ash/manifest.json
[modify] https://crrev.com/b0b10e584b273bbff27a070cba84c3b6242af2bd/ash/mojo_interface_factory.cc
[modify] https://crrev.com/b0b10e584b273bbff27a070cba84c3b6242af2bd/ash/public/interfaces/BUILD.gn
[delete] https://crrev.com/8f88d5d873deb1ce9438dfafa49865097da31e5b/ash/public/interfaces/client_image_registry.mojom
[modify] https://crrev.com/b0b10e584b273bbff27a070cba84c3b6242af2bd/ash/shell.cc
[modify] https://crrev.com/b0b10e584b273bbff27a070cba84c3b6242af2bd/ash/shell.h
[modify] https://crrev.com/b0b10e584b273bbff27a070cba84c3b6242af2bd/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/8f88d5d873deb1ce9438dfafa49865097da31e5b/chrome/browser/ui/ash/browser_image_registrar.cc
[delete] https://crrev.com/8f88d5d873deb1ce9438dfafa49865097da31e5b/chrome/browser/ui/ash/browser_image_registrar.h
[delete] https://crrev.com/8f88d5d873deb1ce9438dfafa49865097da31e5b/chrome/browser/ui/ash/browser_image_registrar_unittest.cc
[modify] https://crrev.com/b0b10e584b273bbff27a070cba84c3b6242af2bd/chrome/test/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d7e5bfc424a14b935a495b62fae29ce38d711c0

commit 5d7e5bfc424a14b935a495b62fae29ce38d711c0
Author: Evan Stade <estade@chromium.org>
Date: Wed Oct 03 21:03:29 2018

Mash: miscellaneous window related cleanups

- remove some window properties that had been used for theming
- remove dead member variable
- update comments
- use remove_standard_frame / kRemoveStandardFrame_InitProperty instead
  of kDisableImmersive_InitProperty for Mash browser windows

Bug:  887051 
Change-Id: Ia7d64acebca600354162be9560bc64761bd3570e
Reviewed-on: https://chromium-review.googlesource.com/c/1255924
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596357}
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/ash/frame/header_view.cc
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/ash/frame/non_client_frame_view_ash_unittest.cc
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/ash/public/cpp/frame_header.cc
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/ash/public/cpp/frame_header.h
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/ash/public/cpp/mus_property_mirror_ash.cc
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/ash/public/cpp/window_properties.h
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/ash/public/interfaces/window_properties.mojom
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/ash/wm/property_util.cc
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/ash/wm/property_util.h
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/ash/wm/window_util.cc
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/chrome/browser/ui/views/frame/browser_frame_mash.cc
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/5d7e5bfc424a14b935a495b62fae29ce38d711c0/services/ws/public/mojom/window_manager.mojom

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2693fe104657ceeb2ffa0db0ff963faf3835c920

commit 2693fe104657ceeb2ffa0db0ff963faf3835c920
Author: Jun Mukai <mukai@chromium.org>
Date: Thu Oct 11 23:03:45 2018

Support of window dragging with touch on Mash

- invokes TransferEventsTo to the gesture recognizer before
  starting the window move session. Otherwise Ash can't consume
  further touch events.
- compute the source pointer location from the event location
  with window's bounds for touch events.
- invoke 'SetHandled' for all GestureEvent, otherwise
  ui::ET_GESTURE_SCROLL_UPDATE event won't be created. This is
  same as c/b/ui/views/tabs/tab_strip.cc.

BUG= 887051 
TEST=manually

Change-Id: I05710b0f11e6a4d9886f192100f3886f4e31a556
Reviewed-on: https://chromium-review.googlesource.com/c/1274457
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599000}
[modify] https://crrev.com/2693fe104657ceeb2ffa0db0ff963faf3835c920/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/2693fe104657ceeb2ffa0db0ff963faf3835c920/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4102566063c7fc9b3e7ca7ce1c8582459804daa

commit a4102566063c7fc9b3e7ca7ce1c8582459804daa
Author: Evan Stade <estade@chromium.org>
Date: Fri Oct 19 16:44:29 2018

Mash: add support for window frame context menus on Ash-provided frames

Adds a single-item context menu for Hosted app windows (teleport
window). This is currently only supported in single process Mash
because multi user window manager doesn't work in multi process Mash.

Bug:  887051 
Change-Id: Ifd1c7a08acf46615ff5fec2f0e7a614c9c99775c
Reviewed-on: https://chromium-review.googlesource.com/c/1287202
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601184}
[modify] https://crrev.com/a4102566063c7fc9b3e7ca7ce1c8582459804daa/ash/frame/non_client_frame_view_ash.cc
[modify] https://crrev.com/a4102566063c7fc9b3e7ca7ce1c8582459804daa/ash/frame/non_client_frame_view_ash.h
[modify] https://crrev.com/a4102566063c7fc9b3e7ca7ce1c8582459804daa/ash/frame/non_client_frame_view_ash_unittest.cc
[modify] https://crrev.com/a4102566063c7fc9b3e7ca7ce1c8582459804daa/ash/frame/wide_frame_view.cc
[modify] https://crrev.com/a4102566063c7fc9b3e7ca7ce1c8582459804daa/ash/public/interfaces/ash_window_manager.mojom
[modify] https://crrev.com/a4102566063c7fc9b3e7ca7ce1c8582459804daa/ash/public/interfaces/menu.mojom
[modify] https://crrev.com/a4102566063c7fc9b3e7ca7ce1c8582459804daa/ash/ws/ash_window_manager.cc
[modify] https://crrev.com/a4102566063c7fc9b3e7ca7ce1c8582459804daa/ash/ws/ash_window_manager.h
[modify] https://crrev.com/a4102566063c7fc9b3e7ca7ce1c8582459804daa/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/a4102566063c7fc9b3e7ca7ce1c8582459804daa/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h

Sign in to add a comment