New issue
Advanced search Search tips

Issue 887050 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 4
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 821009



Sign in to add a comment

Migrate drive::DriveIntegrationService::PreferenceWatcher to NetworkConnectionTracker

Project Member Reported by rmcelrath@chromium.org, Sep 19

Issue description

drive::DriveIntegrationService::PreferenceWatcher currently uses net::NetworkChangeNotifier to be notified of network connection changes. It should be converted to use NetworkConnectionTracker, which will work when the network service is enabled.
 
Owner: rmcelrath@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b28095869d8938998c4d14be9d569a65b4fe31a

commit 3b28095869d8938998c4d14be9d569a65b4fe31a
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Thu Oct 04 20:21:54 2018

Migrate drive::DriveIntegrationService::PreferenceWatcher to NetworkConnectionTracker

This migrates drive::DriveIntegrationService::PreferenceWatcher from
NetworkChangeNotifier to NetworkConnectionTracker, which works with the
network service enabled.

Bug:  887050 
Change-Id: I78bca442c91eb7b348b84429071d03f0988b7e14
Reviewed-on: https://chromium-review.googlesource.com/c/1237537
Reviewed-by: Daichi Hirono <hirono@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596827}
[modify] https://crrev.com/3b28095869d8938998c4d14be9d569a65b4fe31a/chrome/browser/chromeos/drive/drive_integration_service.cc

Status: Fixed (was: Started)

Sign in to add a comment