New issue
Advanced search Search tips

Issue 887046 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 24
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 821009



Sign in to add a comment

Migrate content::PepperNetworkMonitorHost

Project Member Reported by rmcelrath@chromium.org, Sep 19

Issue description

content::PepperNetworkMonitorHost currently uses net::NetworkChangeNotifier to receive network changes. 

With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.
 
Owner: rmcelrath@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd7865c4116b37f68ad0a8fe33ad982ef18de259

commit dd7865c4116b37f68ad0a8fe33ad982ef18de259
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Mon Sep 24 20:58:26 2018

Migrate content::PepperNetworkMonitorHost to NetworkConnectionTracker

This migrates content::PepperNetworkMonitorHost from
NetworkChangeNotifier to NetworkConnectionTracker, which works with the
network service enabled.

Bug:  887046 
Change-Id: I6fcd03fa664689cc6bcc16ff80b86fdba75d695d
Reviewed-on: https://chromium-review.googlesource.com/1236560
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593672}
[modify] https://crrev.com/dd7865c4116b37f68ad0a8fe33ad982ef18de259/content/browser/renderer_host/pepper/pepper_network_monitor_host.cc
[modify] https://crrev.com/dd7865c4116b37f68ad0a8fe33ad982ef18de259/content/browser/renderer_host/pepper/pepper_network_monitor_host.h

Status: Fixed (was: Started)

Sign in to add a comment