New issue
Advanced search Search tips

Issue 887043 link

Starred by 1 user
Status: Fixed
Owner:
rmcelrath@chromium.org
Closed: Sep 24
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 821009



Sign in to add a comment

Migrate extensions::NetworkingPrivateServiceClient to NetworkConnectionTracker

Project Member Reported by rmcelrath@chromium.org, Sep 19 
extensions::NetworkingPrivateServiceClient currently uses net::NetworkChangeNotifier to receive network changes. 

With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.

Comment 1 by rmcelrath@chromium.org, Sep 20

Owner: rmcelrath@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8575ca2b3f6fa4f49d44718bb092ac315920e0ec

commit 8575ca2b3f6fa4f49d44718bb092ac315920e0ec
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Mon Sep 24 20:04:15 2018

Migrate extensions::NetworkingPrivateServiceClient to use NetworkConnectionTracker

This migrates extensions::NetworkingPrivateServiceClient from
NetworkChangeNotifier to NetworkConnectionTracker, which works with the
network service enabled.

Bug:  887043 
Change-Id: I189fc631c5b4050d2e4bffab627754157e9ec20a
Reviewed-on: https://chromium-review.googlesource.com/1237382
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593652}
[modify] https://crrev.com/8575ca2b3f6fa4f49d44718bb092ac315920e0ec/extensions/browser/api/networking_private/networking_private_service_client.cc
[modify] https://crrev.com/8575ca2b3f6fa4f49d44718bb092ac315920e0ec/extensions/browser/api/networking_private/networking_private_service_client.h

Comment 3 by rmcelrath@chromium.org, Sep 24

Status: Fixed (was: Started)
►

Sign in to add a comment