wayland server rejects linux dmabuf param flag ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT
Reported by
blu.d...@gmail.com,
Sep 19
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS aarch64 10895.56.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.95 Safari/537.36 Steps to reproduce the problem: 1. pass flag ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT to zwp_linux_buffer_params_v1_create_immed 2. receive ZWP_LINUX_BUFFER_PARAMS_V1_ERROR_INCOMPLETE "flags not supported" in return What is the expected behavior? wayland server to honor ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT and provide an y-inverted buffer display. What went wrong? ChromeOS wayland server does not support a non-optional wayland flag ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT -- flag should be supported by this version of the protocol. Currently the flag is rejected by the param validation code here: https://chromium.googlesource.com/chromium/src/+/master/components/exo/wayland/server.cc#798 Did this work before? No Chrome version: 69.0.3497.95 Channel: stable OS Version: 10895.56.0 Flash Version:
,
Oct 12
marcheu: sending this to you for triage
,
Oct 20
zachr@ I think you are the best candidate for this bug?
,
Oct 25
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bcce6e85452aad525dd85bd99dd26ea23aef7d0 commit 8bcce6e85452aad525dd85bd99dd26ea23aef7d0 Author: Zach Reizner <zachr@google.com> Date: Wed Oct 31 00:04:37 2018 exo: implement invert_y for linux_dmabuf wayland protocol R=reveman@chromium.org Bug: 887036 Test: wayland client that uses INVERT_Y Change-Id: I9ac108165ac68911ab61b3340410e538f8a843db Reviewed-on: https://chromium-review.googlesource.com/c/1298739 Commit-Queue: Zach Reizner <zachr@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#604066} [modify] https://crrev.com/8bcce6e85452aad525dd85bd99dd26ea23aef7d0/components/exo/buffer.cc [modify] https://crrev.com/8bcce6e85452aad525dd85bd99dd26ea23aef7d0/components/exo/buffer.h [modify] https://crrev.com/8bcce6e85452aad525dd85bd99dd26ea23aef7d0/components/exo/display.cc [modify] https://crrev.com/8bcce6e85452aad525dd85bd99dd26ea23aef7d0/components/exo/display.h [modify] https://crrev.com/8bcce6e85452aad525dd85bd99dd26ea23aef7d0/components/exo/display_unittest.cc [modify] https://crrev.com/8bcce6e85452aad525dd85bd99dd26ea23aef7d0/components/exo/shared_memory.cc [modify] https://crrev.com/8bcce6e85452aad525dd85bd99dd26ea23aef7d0/components/exo/surface.cc [modify] https://crrev.com/8bcce6e85452aad525dd85bd99dd26ea23aef7d0/components/exo/surface.h [modify] https://crrev.com/8bcce6e85452aad525dd85bd99dd26ea23aef7d0/components/exo/surface_unittest.cc [modify] https://crrev.com/8bcce6e85452aad525dd85bd99dd26ea23aef7d0/components/exo/wayland/clients/client_base.cc [modify] https://crrev.com/8bcce6e85452aad525dd85bd99dd26ea23aef7d0/components/exo/wayland/clients/client_base.h [modify] https://crrev.com/8bcce6e85452aad525dd85bd99dd26ea23aef7d0/components/exo/wayland/server.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by dtapu...@chromium.org
, Oct 10