notifier::Login currently uses net::NetworkChangeNotifier to receive network changes. With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3de3d6322f326f6b5570e534fa0866450108ec4c commit 3de3d6322f326f6b5570e534fa0866450108ec4c Author: Robbie McElrath <rmcelrath@chromium.org> Date: Tue Oct 02 21:50:43 2018 Migrate notifier::Login to NetworkConnectionTracker This CL migrates notifier::Login from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. Bug: 887035 Change-Id: Idb43bd5b3159e53d8a3a5f4050d8f4e56db43dee Reviewed-on: https://chromium-review.googlesource.com/c/1235131 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Nicolas Zea <zea@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#595996} [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/chrome/browser/sync/test/integration/sync_test.cc [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/chrome/service/BUILD.gn [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/chrome/service/DEPS [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/chrome/service/cloud_print/cloud_print_proxy.cc [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/chrome/service/cloud_print/cloud_print_proxy.h [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/chrome/service/cloud_print/cloud_print_proxy_backend.cc [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/chrome/service/cloud_print/cloud_print_proxy_backend.h [add] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/chrome/service/net/in_process_network_connection_tracker.cc [add] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/chrome/service/net/in_process_network_connection_tracker.h [add] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/chrome/service/net/in_process_network_connection_tracker_unittest.cc [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/chrome/service/service_process.cc [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/chrome/service/service_process.h [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/chrome/test/BUILD.gn [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/components/invalidation/impl/non_blocking_invalidator_unittest.cc [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/components/invalidation/impl/p2p_invalidation_service.cc [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/components/invalidation/impl/p2p_invalidation_service.h [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/components/invalidation/impl/ticl_invalidation_service.cc [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/jingle/BUILD.gn [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/jingle/notifier/base/notifier_options.cc [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/jingle/notifier/base/notifier_options.h [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/jingle/notifier/communicator/DEPS [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/jingle/notifier/communicator/login.cc [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/jingle/notifier/communicator/login.h [modify] https://crrev.com/3de3d6322f326f6b5570e534fa0866450108ec4c/jingle/notifier/listener/xmpp_push_client.cc
Comment 1 by rmcelrath@chromium.org
, Sep 19