Issue metadata
Sign in to add a comment
|
ARC Bluetooth LE scan concatenates manufacturer data from earlier scan
Reported by
steven.l...@makewonder.com,
Sep 19
|
||||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/11.1.2 Safari/605.1.15
Platform: 10895.56.0
Steps to reproduce the problem:
1. Using Nordic's "nRF Connect" app, scan bluetooth where there is a device which can change the advertised manufacturer data (e.g. Wonder Workshop's Dash robot)
2. Note the raw data in the manufacturer field (field 0xFF)
3. Change the device's advertised manufacturer data (e.g. Put Dash robot in DFU mode by pressing three small top buttons while powering-on)
4. Perform another scan
5. Note the raw data in the manufacturer field
What is the expected behavior?
The manufacturer data field should contain only the data advertised by the device
What went wrong?
The manufacturer data in the second scan is the concatenation of the data from the first scan, with the data from the second, less one byte.
After a reboot of the Chromebook, the manufacturer data is reset.
Attached are screen shots of the initial scan's manufacturer data ("APP mode"), after a second scan once the manufacturer data has changed ("DFU mode after APP mode") and a scan of the second manufacturer data immediately after a reboot ("DFU mode after reboot).
Note that the "DFU mode after app mode" manufacturer data is 57 bytes long, and is a concatenation of the other sets of manufacturer data. Also, manufacturer data is limited to 31 bytes by specification.
Did this work before? Yes 66, perhaps as recently as 68
Chrome version: 69.0.3497.95 Channel: beta
OS Version: 69.0.3497.95
Flash Version: 31.0.0.108
We have previously provided Google with a device to test. Please contact me if you need any further information about this hardware.
,
Sep 25
Also present in beta 70.0.3538.22
,
Sep 28
This may be related and could aid in finding this bug: If the device is turned off during the scan, the manufacturer data immediate increases to 53 bites (in nRF Connect app)
,
Oct 9
This bug continues to occur in 70.0.3538.41
,
Oct 22
Still occurring in beta 70.0.3538.69
,
Oct 29
Still occurring in beta 71.0.3578.21
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/a331e39e54370982829abd0257c2d02950fb476e commit a331e39e54370982829abd0257c2d02950fb476e Author: Qiyu Hu <qiyuh@google.com> Date: Thu Nov 01 04:59:38 2018 chromium: Add EIR as a device property Instead of reconstructing the advertisement data from device properties in ARC++, a proper fix is to keep track of the data package in BlueZ and forward it directly to Android, to avoid an EIR that is too long due to the fact that we cannot distinguish EIR UUIDs from service UUIDs, or idle manufacturer data. BUG= chromium:887029 ,b:118334521 TEST=Manual test, confirmed EIR change from bluetoothctl Change-Id: I8cfa84ef8045a26808e0e9986956b07957c7b70d Reviewed-on: https://chromium-review.googlesource.com/1308457 Commit-Ready: Qiyu Hu <qiyuh@google.com> Tested-by: Qiyu Hu <qiyuh@google.com> Reviewed-by: Dmitry Grinberg <dmitrygr@google.com> [modify] https://crrev.com/a331e39e54370982829abd0257c2d02950fb476e/src/device.h [modify] https://crrev.com/a331e39e54370982829abd0257c2d02950fb476e/src/adapter.c [modify] https://crrev.com/a331e39e54370982829abd0257c2d02950fb476e/doc/device-api.txt [modify] https://crrev.com/a331e39e54370982829abd0257c2d02950fb476e/src/device.c
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f7ec755ab30a72b8edb751703422f145b86549b0 commit f7ec755ab30a72b8edb751703422f145b86549b0 Author: Qiyu Hu <qiyuh@google.com> Date: Fri Nov 02 21:50:49 2018 system_api: Add EIR property in bluetooth_device This was added in crrev.com/c/1308457 BUG= chromium:887029 ,b:118334521 TEST=CQ Change-Id: If80d8fc275e485f4f1db5d3c26e804b28aeaba5a Reviewed-on: https://chromium-review.googlesource.com/1312382 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Qiyu Hu <qiyuh@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f7ec755ab30a72b8edb751703422f145b86549b0/system_api/dbus/service_constants.h
,
Nov 5
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/216f8a0a1e43c0f974a6c5be13a024238c12b642 commit 216f8a0a1e43c0f974a6c5be13a024238c12b642 Author: Qiyu Hu <qiyuh@google.com> Date: Tue Nov 06 20:37:51 2018 Roll src/third_party/cros_system_api/ b54e73475..ef4d21b91 (1 commit) https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/b54e73475dd0..ef4d21b915d8 $ git log b54e73475..ef4d21b91 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 qiyuh system_api: Add EIR property in bluetooth_device Created with: roll-dep src/third_party/cros_system_api Bug: chromium:887029 ,b:118334521 Test: CQ Change-Id: I5514a5a44c0855159bbecfff863a5df2890ad3c7 Reviewed-on: https://chromium-review.googlesource.com/c/1316428 Commit-Queue: Qiyu Hu <qiyuh@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#605810} [modify] https://crrev.com/216f8a0a1e43c0f974a6c5be13a024238c12b642/DEPS
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94876d90a7e227f04fd2dab41d8b3027fb9e4a7e commit 94876d90a7e227f04fd2dab41d8b3027fb9e4a7e Author: Qiyu Hu <qiyuh@google.com> Date: Tue Nov 06 23:46:28 2018 bluetooth: Add EIR as device property CQ-DEPEND=CL:1316428 Bug: chromium:887029 ,b:118334521 Test: unittest Change-Id: I02bf1d4af3f08762c7ecf0ff69637ad53f0e014b Reviewed-on: https://chromium-review.googlesource.com/c/1313412 Commit-Queue: Qiyu Hu <qiyuh@google.com> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#605879} [modify] https://crrev.com/94876d90a7e227f04fd2dab41d8b3027fb9e4a7e/device/bluetooth/bluetooth_adapter.h [modify] https://crrev.com/94876d90a7e227f04fd2dab41d8b3027fb9e4a7e/device/bluetooth/bluez/bluetooth_adapter_bluez.cc [modify] https://crrev.com/94876d90a7e227f04fd2dab41d8b3027fb9e4a7e/device/bluetooth/bluez/bluetooth_adapter_bluez.h [modify] https://crrev.com/94876d90a7e227f04fd2dab41d8b3027fb9e4a7e/device/bluetooth/bluez/bluetooth_bluez_unittest.cc [modify] https://crrev.com/94876d90a7e227f04fd2dab41d8b3027fb9e4a7e/device/bluetooth/dbus/bluetooth_device_client.cc [modify] https://crrev.com/94876d90a7e227f04fd2dab41d8b3027fb9e4a7e/device/bluetooth/dbus/bluetooth_device_client.h [modify] https://crrev.com/94876d90a7e227f04fd2dab41d8b3027fb9e4a7e/device/bluetooth/test/test_bluetooth_adapter_observer.cc [modify] https://crrev.com/94876d90a7e227f04fd2dab41d8b3027fb9e4a7e/device/bluetooth/test/test_bluetooth_adapter_observer.h
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfd3bf4342d4b63a52faa2e4d95852117f3a0092 commit bfd3bf4342d4b63a52faa2e4d95852117f3a0092 Author: Qiyu Hu <qiyuh@google.com> Date: Mon Nov 12 22:52:44 2018 arc: bluetooth: Add EIR as part of OnLEDeviceFound On each LE advertisement event, we forward the event along with the EIR such that it's closer to the behavior in Android. Please review along with ag/5453291 Bug: chromium:887029 ,b:118334521 Test: CtsVerifier Change-Id: I4f56ef5e30087768acb7e897c5345380ffb7a633 Reviewed-on: https://chromium-review.googlesource.com/c/1321581 Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#607362} [modify] https://crrev.com/bfd3bf4342d4b63a52faa2e4d95852117f3a0092/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc [modify] https://crrev.com/bfd3bf4342d4b63a52faa2e4d95852117f3a0092/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.h [modify] https://crrev.com/bfd3bf4342d4b63a52faa2e4d95852117f3a0092/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge_unittest.cc [modify] https://crrev.com/bfd3bf4342d4b63a52faa2e4d95852117f3a0092/components/arc/common/bluetooth.mojom [modify] https://crrev.com/bfd3bf4342d4b63a52faa2e4d95852117f3a0092/components/arc/test/fake_bluetooth_instance.cc [modify] https://crrev.com/bfd3bf4342d4b63a52faa2e4d95852117f3a0092/components/arc/test/fake_bluetooth_instance.h [modify] https://crrev.com/bfd3bf4342d4b63a52faa2e4d95852117f3a0092/device/bluetooth/dbus/fake_bluetooth_device_client.cc [modify] https://crrev.com/bfd3bf4342d4b63a52faa2e4d95852117f3a0092/device/bluetooth/dbus/fake_bluetooth_device_client.h
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/d543711fd64dcd4d334f06a0da5cf6d151540022 commit d543711fd64dcd4d334f06a0da5cf6d151540022 Author: Qiyu Hu <qiyuh@google.com> Date: Fri Dec 07 16:19:32 2018 chromium: Add EIR as a device property Instead of reconstructing the advertisement data from device properties in ARC++, a proper fix is to keep track of the data package in BlueZ and forward it directly to Android, to avoid an EIR that is too long due to the fact that we cannot distinguish EIR UUIDs from service UUIDs, or idle manufacturer data. BUG= chromium:887029 ,b:118334521 TEST=Manual test, confirmed EIR change from bluetoothctl Change-Id: I8cfa84ef8045a26808e0e9986956b07957c7b70d Reviewed-on: https://chromium-review.googlesource.com/1308457 Commit-Ready: Qiyu Hu <qiyuh@google.com> Tested-by: Qiyu Hu <qiyuh@google.com> Reviewed-by: Dmitry Grinberg <dmitrygr@google.com> (cherry picked from commit a331e39e54370982829abd0257c2d02950fb476e) Reviewed-on: https://chromium-review.googlesource.com/c/1361940 Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Benjamin Gordon <bmgordon@chromium.org> Tested-by: Benjamin Gordon <bmgordon@chromium.org> [modify] https://crrev.com/d543711fd64dcd4d334f06a0da5cf6d151540022/src/device.h [modify] https://crrev.com/d543711fd64dcd4d334f06a0da5cf6d151540022/src/adapter.c [modify] https://crrev.com/d543711fd64dcd4d334f06a0da5cf6d151540022/doc/device-api.txt [modify] https://crrev.com/d543711fd64dcd4d334f06a0da5cf6d151540022/src/device.c
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/94e135fbd7cb1acb3b87f81521f95ee58e7a99da commit 94e135fbd7cb1acb3b87f81521f95ee58e7a99da Author: Qiyu Hu <qiyuh@google.com> Date: Fri Dec 07 16:30:48 2018 system_api: Add EIR property in bluetooth_device This was added in crrev.com/c/1308457 BUG= chromium:887029 ,b:118334521 TEST=CQ Change-Id: If80d8fc275e485f4f1db5d3c26e804b28aeaba5a Reviewed-on: https://chromium-review.googlesource.com/1312382 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Qiyu Hu <qiyuh@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit f7ec755ab30a72b8edb751703422f145b86549b0) Reviewed-on: https://chromium-review.googlesource.com/c/1361651 Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Benjamin Gordon <bmgordon@chromium.org> Tested-by: Benjamin Gordon <bmgordon@chromium.org> [modify] https://crrev.com/94e135fbd7cb1acb3b87f81521f95ee58e7a99da/system_api/dbus/service_constants.h
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/system_api/+/ca14da75123ef1055bf2441f2a07869b01fe4728 commit ca14da75123ef1055bf2441f2a07869b01fe4728 Author: Qiyu Hu <qiyuh@google.com> Date: Fri Dec 07 18:31:59 2018 system_api: Add EIR property in bluetooth_device This was added in crrev.com/c/1308457 BUG= chromium:887029 ,b:118334521 TEST=CQ Change-Id: If80d8fc275e485f4f1db5d3c26e804b28aeaba5a Reviewed-on: https://chromium-review.googlesource.com/1312382 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Qiyu Hu <qiyuh@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit f7ec755ab30a72b8edb751703422f145b86549b0) Reviewed-on: https://chromium-review.googlesource.com/c/1361651 Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Benjamin Gordon <bmgordon@chromium.org> Tested-by: Benjamin Gordon <bmgordon@chromium.org> [modify] https://crrev.com/ca14da75123ef1055bf2441f2a07869b01fe4728/dbus/service_constants.h
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bacf960b486c9221bd9a902599d0dabbb197324 commit 6bacf960b486c9221bd9a902599d0dabbb197324 Author: Benjamin Gordon <bmgordon@chromium.org> Date: Fri Dec 07 20:48:41 2018 Roll src/third_party/cros_system_api/ 5a432f7b9d..ca14da7512 (1 commit) https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/5a432f7b9d..ca14da7512 $ git log 5a432f7b9d..ca14da7512 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 qiyuh@google.com system_api: Add EIR property in bluetooth_device Created manually on R71-11151.B release branch. Bug: chromium:887029 ,b:118334521 Test: gclient sync Change-Id: Ib78f0d39c3fc2d3a99f8e024577479f4c63c777d Reviewed-on: https://chromium-review.googlesource.com/c/1368280 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#879} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/6bacf960b486c9221bd9a902599d0dabbb197324/DEPS
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32a445ffbc0bc081e590a0ab2e7a478f2198ee47 commit 32a445ffbc0bc081e590a0ab2e7a478f2198ee47 Author: Qiyu Hu <qiyuh@google.com> Date: Fri Dec 07 20:48:51 2018 bluetooth: Add EIR as device property CQ-DEPEND=CL:1316428 Bug: chromium:887029 ,b:118334521 Test: unittest Change-Id: I02bf1d4af3f08762c7ecf0ff69637ad53f0e014b Reviewed-on: https://chromium-review.googlesource.com/c/1313412 Commit-Queue: Qiyu Hu <qiyuh@google.com> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#605879}(cherry picked from commit 94876d90a7e227f04fd2dab41d8b3027fb9e4a7e) Reviewed-on: https://chromium-review.googlesource.com/c/1361652 Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#880} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/32a445ffbc0bc081e590a0ab2e7a478f2198ee47/device/bluetooth/bluetooth_adapter.h [modify] https://crrev.com/32a445ffbc0bc081e590a0ab2e7a478f2198ee47/device/bluetooth/bluez/bluetooth_adapter_bluez.cc [modify] https://crrev.com/32a445ffbc0bc081e590a0ab2e7a478f2198ee47/device/bluetooth/bluez/bluetooth_adapter_bluez.h [modify] https://crrev.com/32a445ffbc0bc081e590a0ab2e7a478f2198ee47/device/bluetooth/bluez/bluetooth_bluez_unittest.cc [modify] https://crrev.com/32a445ffbc0bc081e590a0ab2e7a478f2198ee47/device/bluetooth/dbus/bluetooth_device_client.cc [modify] https://crrev.com/32a445ffbc0bc081e590a0ab2e7a478f2198ee47/device/bluetooth/dbus/bluetooth_device_client.h [modify] https://crrev.com/32a445ffbc0bc081e590a0ab2e7a478f2198ee47/device/bluetooth/test/test_bluetooth_adapter_observer.cc [modify] https://crrev.com/32a445ffbc0bc081e590a0ab2e7a478f2198ee47/device/bluetooth/test/test_bluetooth_adapter_observer.h
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/492f1526c11b53172eddcc6fe05a9a5cc1d0c8b0 commit 492f1526c11b53172eddcc6fe05a9a5cc1d0c8b0 Author: Benjamin Gordon <bmgordon@chromium.org> Date: Fri Dec 07 20:49:03 2018 arc: bluetooth: Add EIR as part of OnLEDeviceFound On each LE advertisement event, we forward the event along with the EIR such that it's closer to the behavior in Android. Please review along with ag/5699820 Fixed a trivial merge conflict in bluetooth.mojom. Bug: chromium:887029 ,b:118334521 Test: CtsVerifier Change-Id: I4f56ef5e30087768acb7e897c5345380ffb7a633 Reviewed-on: https://chromium-review.googlesource.com/c/1321581 Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Original-Commit-Position: refs/heads/master@{#607362} Reviewed-on: https://chromium-review.googlesource.com/c/1361924 Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#881} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/492f1526c11b53172eddcc6fe05a9a5cc1d0c8b0/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc [modify] https://crrev.com/492f1526c11b53172eddcc6fe05a9a5cc1d0c8b0/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.h [modify] https://crrev.com/492f1526c11b53172eddcc6fe05a9a5cc1d0c8b0/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge_unittest.cc [modify] https://crrev.com/492f1526c11b53172eddcc6fe05a9a5cc1d0c8b0/components/arc/common/bluetooth.mojom [modify] https://crrev.com/492f1526c11b53172eddcc6fe05a9a5cc1d0c8b0/components/arc/test/fake_bluetooth_instance.cc [modify] https://crrev.com/492f1526c11b53172eddcc6fe05a9a5cc1d0c8b0/components/arc/test/fake_bluetooth_instance.h [modify] https://crrev.com/492f1526c11b53172eddcc6fe05a9a5cc1d0c8b0/device/bluetooth/dbus/fake_bluetooth_device_client.cc [modify] https://crrev.com/492f1526c11b53172eddcc6fe05a9a5cc1d0c8b0/device/bluetooth/dbus/fake_bluetooth_device_client.h
,
Dec 7
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 32a445ffbc0bc081e590a0ab2e7a478f2198ee47 was merged to refs/branch-heads/3578 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32a445ffbc0bc081e590a0ab2e7a478f2198ee47 Commit: 32a445ffbc0bc081e590a0ab2e7a478f2198ee47 Author: qiyuh@google.com Commiter: stevenjb@chromium.org Date: 2018-12-07 20:48:51 +0000 UTC bluetooth: Add EIR as device property CQ-DEPEND=CL:1316428 Bug: chromium:887029 ,b:118334521 Test: unittest Change-Id: I02bf1d4af3f08762c7ecf0ff69637ad53f0e014b Reviewed-on: https://chromium-review.googlesource.com/c/1313412 Commit-Queue: Qiyu Hu <qiyuh@google.com> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#605879}(cherry picked from commit 94876d90a7e227f04fd2dab41d8b3027fb9e4a7e) Reviewed-on: https://chromium-review.googlesource.com/c/1361652 Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#880} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Dec 7
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 492f1526c11b53172eddcc6fe05a9a5cc1d0c8b0 was merged to refs/branch-heads/3578 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/492f1526c11b53172eddcc6fe05a9a5cc1d0c8b0 Commit: 492f1526c11b53172eddcc6fe05a9a5cc1d0c8b0 Author: bmgordon@chromium.org Commiter: stevenjb@chromium.org Date: 2018-12-07 20:49:03 +0000 UTC arc: bluetooth: Add EIR as part of OnLEDeviceFound On each LE advertisement event, we forward the event along with the EIR such that it's closer to the behavior in Android. Please review along with ag/5699820 Fixed a trivial merge conflict in bluetooth.mojom. Bug: chromium:887029 ,b:118334521 Test: CtsVerifier Change-Id: I4f56ef5e30087768acb7e897c5345380ffb7a633 Reviewed-on: https://chromium-review.googlesource.com/c/1321581 Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Original-Commit-Position: refs/heads/master@{#607362} Reviewed-on: https://chromium-review.googlesource.com/c/1361924 Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#881} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Dec 7
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 6bacf960b486c9221bd9a902599d0dabbb197324 was merged to refs/branch-heads/3578 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bacf960b486c9221bd9a902599d0dabbb197324 Commit: 6bacf960b486c9221bd9a902599d0dabbb197324 Author: bmgordon@chromium.org Commiter: stevenjb@chromium.org Date: 2018-12-07 20:48:41 +0000 UTC Roll src/third_party/cros_system_api/ 5a432f7b9d..ca14da7512 (1 commit) https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/5a432f7b9d..ca14da7512 $ git log 5a432f7b9d..ca14da7512 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 qiyuh@google.com system_api: Add EIR property in bluetooth_device Created manually on R71-11151.B release branch. Bug: chromium:887029 ,b:118334521 Test: gclient sync Change-Id: Ib78f0d39c3fc2d3a99f8e024577479f4c63c777d Reviewed-on: https://chromium-review.googlesource.com/c/1368280 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#879} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by alph@chromium.org
, Sep 21