Themed tabstrip polish issues with dark theme |
||||||||||
Issue descriptionThemed tabstrip polish issues with dark theme Hey Rob, can you elaborate the ways this theme should be rendered differently? https://chrome.google.com/webstore/detail/marc-ecko/opjonmehjfmkejjifhhknofdnacklmjk Perhaps tabs should be using the stroke? Perhaps active/inactive tabs could be rendered more distinctly? It might be nice if inactive tabs had no background at all, like the default theme...
,
Sep 19
One potential change on the Chrome side may be to change the color of the stroke. Adding pkasting@ and thomasanderson@ for this fun theme issue.
,
Sep 19
I don't have any strong opinions on Chrome's treatment here, perhaps it does come down to the theme. I mainly filed this bug at Rob's request, feel free to morph or close it as appropriate. I do really like how the classic theme doesn't paint an inactive tab background at all. The simple separator definitely looks cleaner, but I guess it all depends on the theme.
,
Sep 19
@2: For stroke colors, since the theme here isn't using a stroke, I don't know what color it would be drawn. That said, Monica would like themes to have programmatic control over the stroke (at least color, maybe other stuff). @3: The theme controls whether it wants an inactive tab background, so we could change the theme here to avoid those. I think in the end this is one where we should just update the theme to look better. Who owns these?
,
Sep 20
,
Sep 20
,
Sep 26
,
Sep 28
Reassigning to rameier@
,
Sep 28
,
Nov 19
,
Dec 11
,
Jan 15
Mass-unassigning bugs from rameier@. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by pkasting@chromium.org
, Sep 19