New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 887002 link

Starred by 1 user
Status: Fixed
Owner:
liaoyuke@chromium.org
Closed: Sep 19
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

test_suite_name is incorrect for webkit_layout_tests

Project Member Reported by liaoyuke@chromium.org, Sep 19 
Currently, test_suite_name is calculated by:

test_name_parts = normalized_test_name.split('.')
if len(test_name_parts) == 2:
  test_suite_name = test_name_parts[0]

It's not correct for webkit_layout_tests, for example, 'a/b/c/d.html' will be treated as a gtest, and the test_suite_name is 'a/b/c/d'
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4352ffdae22dbf2362fb92d56a4c203d6a0d8db0

commit 4352ffdae22dbf2362fb92d56a4c203d6a0d8db0
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Sep 19 23:11:13 2018

[Findit] Fix a bug in calculating test suite name

There was a bug in the function to calcualte test suite name:
'a/b/c.html' is a webkit layout tests, but it was incorrectly treated as
a gtest, and returns 'a/b/c' as its suite part.

Bug:  887002 
Change-Id: I721ad6ebb29345f6090206178712122f543f21ed
Reviewed-on: https://chromium-review.googlesource.com/1235139
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17742}
[modify] https://crrev.com/4352ffdae22dbf2362fb92d56a4c203d6a0d8db0/appengine/findit/model/flake/test/flake_test.py
[modify] https://crrev.com/4352ffdae22dbf2362fb92d56a4c203d6a0d8db0/appengine/findit/model/flake/flake.py

Comment 2 by liaoyuke@chromium.org, Sep 19

Status: Fixed (was: Assigned)
►

Sign in to add a comment