Issue metadata
Sign in to add a comment
|
16.7%-19.8% regression in media_perftests at 592253:592295 |
||||||||||||||||||||
Issue descriptionSignificant drop in runs/s for clockless playback tests.
,
Sep 19
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/133ab248e40000
,
Sep 20
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/133ab248e40000 Don't hold audio rendering lock while reading from demuxer. by dalecurtis@chromium.org https://chromium.googlesource.com/chromium/src/+/fae6a1ad5b8311783f42221073e262b2897e8087 1.282e+04 → 1.079e+04 (-2022) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Sep 20
Huh, didn't expect this, but thinking about how the clockless tests work it's not surprising. Clockless playback is a repeated post task acquiring the lock as fast as possible, so yielding it here means we miss the opportunity to fulfill the read right away. In practice this shouldn't be an issue since real playback doesn't lock like that -- so WontFix.
,
Sep 24
Issue 888065 has been merged into this issue. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Sep 19