New issue
Advanced search Search tips

Issue 886973 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 812040



Sign in to add a comment

Clean up offline Demo Mode policy resources

Project Member Reported by michae...@chromium.org, Sep 19

Issue description

The CrOS build installs resources for offline Demo Mode into a few places. 

We should remove chromeos-assets from the workflow and stop installing policy into /usr/share/chromeos-assets, because that's unused now. We should also start loading policy from the mounted offline resources image and remove it from /usr/share/demo_mode_resources.
 
Owner: tbarzic@chromium.org
Labels: -M-71 M-72
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/84df1747ac9b064e2016a4d03439acf19dc94043

commit 84df1747ac9b064e2016a4d03439acf19dc94043
Author: Toni Barzic <tbarzic@google.com>
Date: Tue Oct 16 21:25:23 2018

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/9adad8803736017905865e6411c16ed626a5c3cc

commit 9adad8803736017905865e6411c16ed626a5c3cc
Author: Toni Barzic <tbarzic@google.com>
Date: Tue Oct 16 21:25:24 2018

Cc: tbarzic@chromium.org
Owner: michae...@chromium.org
Labels: -M-72 M-73
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fb7bc99fb5065349b738c0840dea34c812a1292

commit 7fb7bc99fb5065349b738c0840dea34c812a1292
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Mon Jan 14 19:41:36 2019

Install offline Demo Mode policy from offline resources

During offline Demo Mode setup, install the policy files from the
preinstalled offline resources, rather than rootfs.

In CrOS, the files will be removed from rootfs and added to the
offline-demo-mode-resources component.

Bug: 886973
Change-Id: Ia947c9f1d2c2df2da997539c581338efeb82a814
Reviewed-on: https://chromium-review.googlesource.com/c/1407601
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622552}
[modify] https://crrev.com/7fb7bc99fb5065349b738c0840dea34c812a1292/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/7fb7bc99fb5065349b738c0840dea34c812a1292/chrome/browser/chromeos/login/demo_mode/demo_setup_browsertest.cc
[modify] https://crrev.com/7fb7bc99fb5065349b738c0840dea34c812a1292/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
[modify] https://crrev.com/7fb7bc99fb5065349b738c0840dea34c812a1292/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.h
[modify] https://crrev.com/7fb7bc99fb5065349b738c0840dea34c812a1292/chrome/browser/chromeos/login/demo_mode/demo_setup_controller_unittest.cc
[modify] https://crrev.com/7fb7bc99fb5065349b738c0840dea34c812a1292/chrome/browser/chromeos/login/demo_mode/demo_setup_test_utils.cc
[modify] https://crrev.com/7fb7bc99fb5065349b738c0840dea34c812a1292/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc

Sign in to add a comment