New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 886965 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Ensure all perf benchmarks have component field specified

Project Member Reported by nednguyen@chromium.org, Sep 19

Issue description

This is to make sure that we can efficiently triage regressions/problems related to benchmarks.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2082aa2352cae2409ea1f102c52d7daa53daa13a

commit 2082aa2352cae2409ea1f102c52d7daa53daa13a
Author: Ned Nguyen <nednguyen@google.com>
Date: Wed Sep 19 17:52:26 2018

Add components for dummy telemetry benchmarks

These benchmarks are handy for integration testing our pipeline & to dogfood new
big features launch, so keeping them around.

*This is part of the effort to add bug components for all perf benchmarks.

Change-Id: Id8d8dee935ccc8b58186b2c6f3ec9ea6e5711397
BUG: 886965
Reviewed-on: https://chromium-review.googlesource.com/1234314
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592463}
[modify] https://crrev.com/2082aa2352cae2409ea1f102c52d7daa53daa13a/tools/perf/benchmark.csv
[modify] https://crrev.com/2082aa2352cae2409ea1f102c52d7daa53daa13a/tools/perf/benchmarks/dummy_benchmark.py

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e655e23f43320c66976684a462a6b24ccea04e33

commit e655e23f43320c66976684a462a6b24ccea04e33
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Sep 19 22:16:04 2018

Update component for blink_perf.accessibility

Bug: 886965
Change-Id: Ic3e6eb01394e01343e4eb6da47b064ff6c7cad7d
Reviewed-on: https://chromium-review.googlesource.com/1234325
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#592572}
[modify] https://crrev.com/e655e23f43320c66976684a462a6b24ccea04e33/tools/perf/benchmark.csv
[modify] https://crrev.com/e655e23f43320c66976684a462a6b24ccea04e33/tools/perf/benchmarks/blink_perf.py

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/720815deb35b8db2c10ede8187e0d6311a5acc47

commit 720815deb35b8db2c10ede8187e0d6311a5acc47
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Thu Sep 20 01:31:31 2018

Add component Internals>Media for media_perftests.

Bug: 886965
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I84c96f5d3399a20b83a98ec68f1157eac2d67685
Reviewed-on: https://chromium-review.googlesource.com/1235281
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592653}
[modify] https://crrev.com/720815deb35b8db2c10ede8187e0d6311a5acc47/tools/perf/benchmark.csv
[modify] https://crrev.com/720815deb35b8db2c10ede8187e0d6311a5acc47/tools/perf/core/perf_data_generator.py

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a733aa2e814abdab37b30deae0e780ee1dc2f282

commit a733aa2e814abdab37b30deae0e780ee1dc2f282
Author: Camillo Bruni <cbruni@chromium.org>
Date: Wed Sep 26 19:55:55 2018

[perf] Adding new owner and component for v8.runtime_stats.top25 benchmark

Change-Id: Ic2248c098bf0f7c965ae09ebcbf552a0bebf430e
Bug: 886965
Reviewed-on: https://chromium-review.googlesource.com/1245703
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594442}
[modify] https://crrev.com/a733aa2e814abdab37b30deae0e780ee1dc2f282/tools/perf/benchmark.csv
[modify] https://crrev.com/a733aa2e814abdab37b30deae0e780ee1dc2f282/tools/perf/benchmarks/v8.py

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/764826c5cb75fce8efe3a6c4f34b6b25b38b3976

commit 764826c5cb75fce8efe3a6c4f34b6b25b38b3976
Author: Fernando Serboncini <fserb@chromium.org>
Date: Tue Oct 09 16:36:32 2018

Update benchmark component for blink_perf.Canvas

Change-Id: I5c0a8f63a40c7cad8c44aa0b1d9089798e1293c6

Bug: 886965
Change-Id: I5c0a8f63a40c7cad8c44aa0b1d9089798e1293c6
Reviewed-on: https://chromium-review.googlesource.com/c/1254561
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#597944}
[modify] https://crrev.com/764826c5cb75fce8efe3a6c4f34b6b25b38b3976/tools/perf/benchmark.csv
[modify] https://crrev.com/764826c5cb75fce8efe3a6c4f34b6b25b38b3976/tools/perf/benchmarks/blink_perf.py

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment