New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 886956 link

Starred by 1 user
Status: Fixed
Owner:
jzw@chromium.org
Closed: Oct 12
Cc:
█ ichikawa@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Expose scrollViewShouldScrollToTop: from CWVScrollView

Project Member Reported by jzw@chromium.org, Sep 19 
Client apps may wish to use scrollViewShouldScrollToTop: to dynamically adjust scrollsToTop behavior.

Comment 1 by eugene...@chromium.org, Sep 20

Labels: -Type-Feature Type-Task
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55f625fac508a37671e1688c697d4d57d9f1bdc8

commit 55f625fac508a37671e1688c697d4d57d9f1bdc8
Author: John Z Wu <jzw@chromium.org>
Date: Fri Sep 28 06:44:52 2018

Forward -[UIScrollViewDelegate scrollViewShouldScrollTop:].

Bug:  886956 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ida9f92b1bea9093d6a46b5d9eeb4ee7da4306141
Reviewed-on: https://chromium-review.googlesource.com/1249919
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595000}
[modify] https://crrev.com/55f625fac508a37671e1688c697d4d57d9f1bdc8/ios/web_view/BUILD.gn
[modify] https://crrev.com/55f625fac508a37671e1688c697d4d57d9f1bdc8/ios/web_view/internal/cwv_scroll_view.mm
[add] https://crrev.com/55f625fac508a37671e1688c697d4d57d9f1bdc8/ios/web_view/internal/cwv_scroll_view_unittest.mm
[modify] https://crrev.com/55f625fac508a37671e1688c697d4d57d9f1bdc8/ios/web_view/public/cwv_scroll_view_delegate.h

Comment 3 by jzw@chromium.org, Oct 12

Status: Fixed (was: Available)
►

Sign in to add a comment