New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 886939 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move telemetry back to Chromium/src

Project Member Reported by nednguyen@chromium.org, Sep 19

Issue description

This is the meta bug for moving Telemetry to Chromium/src. The rationales are:
1) Most of the known customers of Telemetry are benchmarks & tests in chromium/src/. Putting Telemetry in Catapult repo slow down the development cycle as API updates require 3/4 sided patches and devs sometimes need to wait for the roll to know they broke tests (e.g:  issue 886913 ).
2) For clients that want benchmark which are not in Chromium/src, they either don't need Telemetry or there are other ways to get Telemetry:
  i) If they want performance benchmark for web development, lighthouse (https://developers.google.com/web/tools/lighthouse/) is the recommended framework. Notes that making Telemetry a perf test framework for webdevs was the original reason why we moved Telemetry to catapult and that vision is now fulfilled by LightHouse.

  ii) If they still want Telemetry for benchmarking, they can use Telemetry isolate through running: python tools/mb/mb.py zip out/Release telemetry_gpu_integration_test_scripts_only out/my_scripts.zip


Few more details still need to be fleshed out for this bug:
1) What to do about Telemetry's deps like vinn/ or devil/ ?
2) What is our testing look like? Should we add telemetry_unittest_references to Chromium CQ to ensure we don't lose Telemetry ref build coverage?

 
I would imagine if there was a need to pull telemetry in as a separate repo we could split one out via gsubtreed, right?
#1: yes. But so far I haven't found any major clients wanting Telemetry alone. If they want it, they also wants the files in https://cs.chromium.org/chromium/src/tools/perf/
+1 to this proposal. It should make things easier to maintain and update.

It makes more sense for webdevs to use ChromeDriver since it supports W3C WebDriver standard, so whatever they do will work for other browsers as well. Even if they don't want something that works for other browsers, ChromeDriver should still work fine for them.
devil is also used by systrace. if the latter is staying in catapult, i think the former will have to as well.
Cc: ccraik@google.com jreck@google.com
+jreck and ccraik, systrace OWNERS ( https://github.com/catapult-project/catapult/blob/master/systrace/OWNERS )
Could systrace be moved into Chromium if Devil and Telemetry were being moved?

Comment 6 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 7 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry

Comment 8 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment