New issue
Advanced search Search tips

Issue 886932 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug
Build-Toolchain



Sign in to add a comment

Chrome failing to build because of undefined cupsGetPPD2

Project Member Reported by manojgupta@chromium.org, Sep 19

Issue description

Hitting this error in toolchain team nightly jobs using *-release builds with --latest-toolchain. The error message is generic enough so not sure how did it pass PFQ.

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8934972947422419616

chromeos-chrome-71.0.3555.0_rc-r1: FAILED: obj/printing/printing/cups_printer.o 
chromeos-chrome-71.0.3555.0_rc-r1: armv7a-cros-linux-gnueabi-clang++ -B/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.27.0-gold -MMD -MF obj/printing/printing/cups_printer.o.d -DPRINTING_IMPLEMENTATION -DPRINT_BACKEND_AVAILABLE -DPRINT_BACKEND_AVAILABLE -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D_GNU_SOURCE -DCR_CLANG_REVISION=\"340925-2\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DCR_SYSROOT_HASH=b732cc2c870314130b767557b34764f8dd0a3df8 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_CUPS -DWEBP_EXTERN=extern -DUSE_EGL -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -I../../../../../../../home/chrome-bot/chrome_root/src -Igen -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libwebp/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos -I../../../../../../../home/chrome-bot/chrome_root/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libyuv/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/ced/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/common -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/i18n -I../../../../../../../home/chrome-bot/chrome_root/src/skia/config -I../../../../../../../home/chrome-bot/chrome_root/src/skia/ext -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/c -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/config -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/core -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/effects -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/encode -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/images -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/lazy -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pathops -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pdf -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pipe -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/ports -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/utils -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/sksl -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/modules/skottie/include -fno-strict-aliasing -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -no-canonical-prefixes -flto=thin -fwhole-program-vtables --target=arm-linux-gnueabihf -march=armv8-a+crc -mfloat-abi=hard -mtune=generic-armv7-a -mfpu=neon -mthumb -Wall -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g2 -gsplit-dwarf -ggnu-pubnames -fsanitize=cfi-vcall -fsanitize-blacklist=../../../../../../../home/chrome-bot/chrome_root/src/tools/cfi/blacklist.txt -fsanitize=cfi-derived-cast -fsanitize=cfi-unrelated-cast -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=c++14 -fno-exceptions -fno-rtti --sysroot=../../../../../../../build/bob -fvisibility-inlines-hidden -pipe -march=armv8-a+crc -mtune=cortex-a57.cortex-a53 -mfpu=crypto-neon-fp-armv8 -mfloat-abi=hard -fno-split-dwarf-inlining -D__google_stl_debug_vector=1 -Wno-unknown-warning-option -stdlib=libc++ -fprofile-sample-use=/build/bob/tmp/portage/chromeos-base/chromeos-chrome-71.0.3555.0_rc-r1/work/afdo/silvermont_R71-3538.7-1537178702.afdo -Wno-error -c ../../../../../../../home/chrome-bot/chrome_root/src/printing/backend/cups_printer.cc -o obj/printing/printing/cups_printer.o
chromeos-chrome-71.0.3555.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/printing/backend/cups_printer.cc:131:30: error: use of undeclared identifier 'cupsGetPPD2'
chromeos-chrome-71.0.3555.0_rc-r1:   const char* ppd_path_str = cupsGetPPD2(cups_http_, printer_name);
chromeos-chrome-71.0.3555.0_rc-r1:                              ^
chromeos-chrome-71.0.3555.0_rc-r1: 1 error generated.

 
Components: Internals>Printing>CUPS
Labels: -Pri-2 Pri-1
Summary: Chrome failing to build because of undefined cupsGetPPD2 (was: Chrome failing to build in llvm-next builds (error in cupsGetPPD2))
Also seeing this error in kevin-release, so suspect all canary builds are seeing this problem.

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8934963581363814416
Cc: manojgupta@chromium.org valleau@chromium.org skau@chromium.org
Owner: valleau@chromium.org
Suspect CL: https://chromium-review.googlesource.com/c/chromiumos/manifest/+/1192229
Labels: -Pri-1 Pri-0
Status: Assigned (was: Untriaged)
This is breaking the PFQ also.

The first failing amd64-generic PFQ builder shows a bunch of CUPS related changes were chumped:

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8934979866226024400

We're still seeing PFQ failures due to undefined cupsGetPPD2 errors.
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c27c50cb0cd5b6f0cb3d5be578ae1debafd374d0

commit c27c50cb0cd5b6f0cb3d5be578ae1debafd374d0
Author: David Valleau <valleau@chromium.org>
Date: Wed Oct 10 20:30:09 2018

Removing GetPrinterCapsAndDefaults for Chrome OS builds

GetPrinterCapsAndDefaults is dead code in Chrome OS, and was causing
build failures with the update to CUPS 2.2.8 so it is being removed.

R=skau@chromium.org

Bug:  886932 
Change-Id: Ic21dd3db15e7cfd225000dd6db4d59157aa5c385
Reviewed-on: https://chromium-review.googlesource.com/c/1258511
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598479}
[modify] https://crrev.com/c27c50cb0cd5b6f0cb3d5be578ae1debafd374d0/printing/backend/cups_printer.cc
[modify] https://crrev.com/c27c50cb0cd5b6f0cb3d5be578ae1debafd374d0/printing/backend/print_backend.h
[modify] https://crrev.com/c27c50cb0cd5b6f0cb3d5be578ae1debafd374d0/printing/backend/print_backend_chromeos.cc
[modify] https://crrev.com/c27c50cb0cd5b6f0cb3d5be578ae1debafd374d0/printing/backend/print_backend_cups_ipp.cc
[modify] https://crrev.com/c27c50cb0cd5b6f0cb3d5be578ae1debafd374d0/printing/backend/print_backend_cups_ipp.h
[modify] https://crrev.com/c27c50cb0cd5b6f0cb3d5be578ae1debafd374d0/printing/backend/test_print_backend.cc
[modify] https://crrev.com/c27c50cb0cd5b6f0cb3d5be578ae1debafd374d0/printing/backend/test_print_backend.h

Status: Verified (was: Started)
No longer seeing these fails.

Sign in to add a comment