New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 886919 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Fix hands-off enrollment in OOBE

Project Member Reported by agawronska@chromium.org, Sep 19

Issue description

New welcome screen does not wait for the network which breaks hands-off enrollment.
Regression introduced by: https://chromium-review.googlesource.com/c/chromium/src/+/1139586.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/741a46dd1763136d61840d34642ce5a645ee4933

commit 741a46dd1763136d61840d34642ce5a645ee4933
Author: Aga Wronska <agawronska@chromium.org>
Date: Mon Sep 24 16:59:46 2018

Fix hands-off enrollment OOBE flow.

Automatically continue from welcome to network screen when hands-off
enrollment is in progress.

This fixes the regression introduced by split of welcome screen into
welcome and network screen:
https://chromium-review.googlesource.com/c/chromium/src/+/1139586

Bug:  886919 
Test: HandsOffEnrollmentTest + manually
Change-Id: I9f5fe438c5dd7284973e76728c4204b4cad2ea52
Reviewed-on: https://chromium-review.googlesource.com/1236662
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593573}
[modify] https://crrev.com/741a46dd1763136d61840d34642ce5a645ee4933/chrome/browser/chromeos/login/enrollment/enrollment_screen.cc
[add] https://crrev.com/741a46dd1763136d61840d34642ce5a645ee4933/chrome/browser/chromeos/login/enrollment/hands_off_enrollment_browsertest.cc
[modify] https://crrev.com/741a46dd1763136d61840d34642ce5a645ee4933/chrome/browser/chromeos/login/screens/welcome_screen.cc
[modify] https://crrev.com/741a46dd1763136d61840d34642ce5a645ee4933/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/741a46dd1763136d61840d34642ce5a645ee4933/chrome/test/BUILD.gn

Status: Fixed (was: Started)
Labels: Merge-Request-70
The fix was verified on M71 branch.

I would like to merge into M70, because hands-off enrollment is broken there.

The actual code change is 10 lines (the rest of the CL contains tests), so it should be easy/safe merge into M70.
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 26

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 28

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7603eba48305b99da5e0b87ea6bf6869e871e6ae

commit 7603eba48305b99da5e0b87ea6bf6869e871e6ae
Author: Aga Wronska <agawronska@chromium.org>
Date: Fri Sep 28 02:50:13 2018

Fix hands-off enrollment OOBE flow.

Automatically continue from welcome to network screen when hands-off
enrollment is in progress.

This fixes the regression introduced by split of welcome screen into
welcome and network screen:
https://chromium-review.googlesource.com/c/chromium/src/+/1139586

(cherry picked from commit 741a46dd1763136d61840d34642ce5a645ee4933)

Bug:  886919 
Test: HandsOffEnrollmentTest + manually
Change-Id: I9f5fe438c5dd7284973e76728c4204b4cad2ea52
Reviewed-on: https://chromium-review.googlesource.com/1236662
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593573}
Reviewed-on: https://chromium-review.googlesource.com/1249492
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#724}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/7603eba48305b99da5e0b87ea6bf6869e871e6ae/chrome/browser/chromeos/login/enrollment/enrollment_screen.cc
[add] https://crrev.com/7603eba48305b99da5e0b87ea6bf6869e871e6ae/chrome/browser/chromeos/login/enrollment/hands_off_enrollment_browsertest.cc
[modify] https://crrev.com/7603eba48305b99da5e0b87ea6bf6869e871e6ae/chrome/browser/chromeos/login/screens/welcome_screen.cc
[modify] https://crrev.com/7603eba48305b99da5e0b87ea6bf6869e871e6ae/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/7603eba48305b99da5e0b87ea6bf6869e871e6ae/chrome/test/BUILD.gn

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/7603eba48305b99da5e0b87ea6bf6869e871e6ae

Commit: 7603eba48305b99da5e0b87ea6bf6869e871e6ae
Author: agawronska@chromium.org
Commiter: agawronska@chromium.org
Date: 2018-09-28 02:50:13 +0000 UTC

Fix hands-off enrollment OOBE flow.

Automatically continue from welcome to network screen when hands-off
enrollment is in progress.

This fixes the regression introduced by split of welcome screen into
welcome and network screen:
https://chromium-review.googlesource.com/c/chromium/src/+/1139586

(cherry picked from commit 741a46dd1763136d61840d34642ce5a645ee4933)

Bug:  886919 
Test: HandsOffEnrollmentTest + manually
Change-Id: I9f5fe438c5dd7284973e76728c4204b4cad2ea52
Reviewed-on: https://chromium-review.googlesource.com/1236662
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593573}
Reviewed-on: https://chromium-review.googlesource.com/1249492
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#724}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Hi Aga,

could you please provide the verification steps for this bug?

Thanks,
Ivan
0. Pre-provision device in the enterprise domain [*]   
1. Set --enterprise-enable-zero-touch-enrollment=hands-off flag
2. Put device in OOBE
3. Connect device to network  
4. Observe that device automatically goes through OOBE:
welcome screen -> network screen (waits for network to be connected) -> EULA screen -> update screen -> enrollment screen

[*] If you skip pre-provisioning step, device will try to enroll, but enrollment will fail. That is sufficient fine for verification of this issue.  
Status: Verified (was: Fixed)
Thanks, Aga!

I was able to repro this on 11021.31.0, 70.0.3538.38 and verify on 	11021.34.0, 70.0.3538.41. Also verified on 11120.0.0, 71.0.3567.0.

Sign in to add a comment