New issue
Advanced search Search tips

Issue 886898 link

Starred by 1 user
Status: Fixed
Owner:
wanderview@chromium.org
Closed: Sep 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 885347



Sign in to add a comment

measure where cache_storage hits kErrorStorage

Project Member Reported by wanderview@chromium.org, Sep 19 
The cache_storage code has a number of code paths that result in the generic kErrorStorage.  This results in a rejection message of "Unexpected internal error".  Lets add a histogram so we can see determine if any of these codepaths is problematic since we can't tell from the error messages reported in bugs.

Comment 1 by jsb...@chromium.org, Sep 20

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efacae11a62742c43d09831c15245204356923c4

commit efacae11a62742c43d09831c15245204356923c4
Author: Ben Kelly <wanderview@chromium.org>
Date: Thu Sep 20 21:55:43 2018

Add a histogram recording how cache_storage hits kErrorStorage.

R=jsbell@chromium.org, rkaplow@chromium.org

Bug:  886898 
Change-Id: I7519c327419c81b5eeb9dd83ac17850114a3795f
Reviewed-on: https://chromium-review.googlesource.com/1234636
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592962}
[modify] https://crrev.com/efacae11a62742c43d09831c15245204356923c4/content/browser/BUILD.gn
[modify] https://crrev.com/efacae11a62742c43d09831c15245204356923c4/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/efacae11a62742c43d09831c15245204356923c4/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/efacae11a62742c43d09831c15245204356923c4/content/browser/cache_storage/cache_storage_cache_unittest.cc
[add] https://crrev.com/efacae11a62742c43d09831c15245204356923c4/content/browser/cache_storage/cache_storage_histogram_utils.cc
[rename] https://crrev.com/efacae11a62742c43d09831c15245204356923c4/content/browser/cache_storage/cache_storage_histogram_utils.h
[modify] https://crrev.com/efacae11a62742c43d09831c15245204356923c4/content/browser/cache_storage/cache_storage_operation.cc
[modify] https://crrev.com/efacae11a62742c43d09831c15245204356923c4/content/browser/cache_storage/cache_storage_scheduler.cc
[modify] https://crrev.com/efacae11a62742c43d09831c15245204356923c4/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/efacae11a62742c43d09831c15245204356923c4/tools/metrics/histograms/histograms.xml

Comment 3 by wanderview@chromium.org, Sep 21

Status: Fixed (was: Started)
►

Sign in to add a comment