New issue
Advanced search Search tips

Issue 886897 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 884675



Sign in to add a comment

Support showing shortcuts in the OmniboxPopupViewController

Project Member Reported by stkhapugin@chromium.org, Sep 19

Issue description

The view controller should have API that allows showing shortcuts when there are no autocomplete results to display. 

It should be runtime-specified so that this can be toggled conditionally, for example when it shouldn't be shown on NTP. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4da02a0f4dcc4c366b1dddd17e3c32f63090dc09

commit 4da02a0f4dcc4c366b1dddd17e3c32f63090dc09
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Tue Oct 02 13:18:11 2018

[iOS] Add support for shortcuts in the popup view controller.

Adds support for showing shortcuts in the popup view controller when no
suggestions are shown.

Since the actual shortcuts are not implemented yet, a placeholder is
displayed.

Bug:  886897 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ie9afb4933b42b846d5177c1024feebf9241afdee
Reviewed-on: https://chromium-review.googlesource.com/1233706
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595814}
[modify] https://crrev.com/4da02a0f4dcc4c366b1dddd17e3c32f63090dc09/ios/chrome/browser/ui/omnibox/popup/BUILD.gn
[modify] https://crrev.com/4da02a0f4dcc4c366b1dddd17e3c32f63090dc09/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.h
[modify] https://crrev.com/4da02a0f4dcc4c366b1dddd17e3c32f63090dc09/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm
[add] https://crrev.com/4da02a0f4dcc4c366b1dddd17e3c32f63090dc09/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller_unittest.mm
[modify] https://crrev.com/4da02a0f4dcc4c366b1dddd17e3c32f63090dc09/ios/chrome/test/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment