New issue
Advanced search Search tips

Issue 886854 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Sep 24
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary "Scale" textbox get focused when nearby space of textbox is tap touched

Reported by khushal....@etouch.net, Sep 19 
Chrome Version: 71.0.3556.0 (Official Build) Revision bd6b4db905b5d51ca0ab759729efca79bc0a6046-refs/branch-heads/3556@{#1} (64-bit)

OS: Windows 10 (Touch device)

What steps will reproduce the problem?
(1) Launch chrome and press 'Cmd+P' to open Print Preview.
(2) Tap touch on 'More settings' to expand.
(3) Now touch on the space nearby "Scale" textbox and Observe.

Actual Result: Unnecessary "Scale" textbox get focused when nearby space of textbox is tap touched.

Expected Result: "Scale" textbox should not get focused when nearby space of textbox is tap touched.

This is a regression issue, broken in M-71 series, below is manual regression range:
Good build: 71.0.3551.0 (Revision: 590851)
Bad build:  71.0.3552.2 (Revision: 591210)

Using the 'per-revision' script providing the bisect result:

You are probably looking for a change made after 591108 (known good), but no later than 591109 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/974aa7b559b4361d7410479796becb0b933dc6a4..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

Suspecting: https://chromium.googlesource.com/chromium/src/+/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE:
1) Issue is also seen on M-71 Dev #71.0.3554.0.
2) Issue is Touch specific and it is not seen on Click event.
3) Issue is not seen on Linux (14.04 LTS), Mac (10.12.6, 10.13.1, 10.13.6, 10.14) & Win (7, 8, 8.1, 10) device.

Kindly refer the attached screen-cast.

Thank You..!!
Actual Video.mov
7.2 MB View Download
Expected Video.mov
5.2 MB View Download

Comment 1 by telaine....@gmail.com, Sep 19 

This is a bug

Comment 2 by khushal....@etouch.net, Sep 20 

Correction:

Attaching correct videos (actual and expected) for reference.

Thank You..!!
Actual Video.mp4
518 KB View Download
Expected Video.mp4
212 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/401094d9d99a8404a9fde5791fc61ded27e03bbd

commit 401094d9d99a8404a9fde5791fc61ded27e03bbd
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Sep 21 17:53:25 2018

Print Preview refresh: Fix some scaling bugs

2 bugs in the scaling section:
(1) Fix a pre-existing bug where the scaling input incorrectly displayed
0 and an error when fit to page was checked for a non-uniform page
size PDF
(2) Prevent cr-input from expanding to the full row to try
to fix a bug with touch on Windows.

Bug:  874226 ,  886854 
Change-Id: I8cb8785129f125a17a2ea8715ec85af3b467cad8
Reviewed-on: https://chromium-review.googlesource.com/1237516
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593249}
[modify] https://crrev.com/401094d9d99a8404a9fde5791fc61ded27e03bbd/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/401094d9d99a8404a9fde5791fc61ded27e03bbd/chrome/browser/resources/print_preview/new/scaling_settings.js

Comment 4 by khushal....@etouch.net, Sep 24

Labels: TE-Verified-M71 TE-Verified-71.0.3559.0
Update:

Rechecked the above issue on Windows 10 (Touch device) using latest Canary version #71.0.3559.0 and the issue is found FIXED. Hence, adding respective Labels.

Kindly refer the attached screen-cast.

Thank you..!!
Fixed Video.mp4
397 KB View Download

Comment 5 by rbpotter@chromium.org, Sep 24

Status: Verified (was: Assigned)
►

Sign in to add a comment