New issue
Advanced search Search tips

Issue 886800 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Sep 27
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Focus navigation is not seen properly after clearing text from 'Scale'.

Reported by db...@etouch.net, Sep 19 
Chrome Version: 71.0.3556.0 Revision bd6b4db905b5d51ca0ab759729efca79bc0a6046-refs/branch-heads/3556@{#1}(32/)
OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTs).

What steps will reproduce the problem?
(1) Launch chrome, open NTP and give 'Print' command using Ctrl+P
(2) Click on 'More settings, press Tab key upto focus reaches to Scale, clear text in scale.
(3) Now again press Tab key and observe.

Actual: Focus navigation is not seen properly after clearing text from Scale.

Expected: Focus navigation should seen properly after clearing text from Scale.

This is regression issue broken in ‘M-71’ and below is the bisect info:
Good build: 71.0.3551.3 (Revision: 590851)
Bad build : 71.0.3552.2 (Revision: 591210)

Using the 'per-revision' script providing the bisect result:

You are probably looking for a change made after 591108 (known good), but no later than 591109 (first known bad).
CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/974aa7b559b4361d7410479796becb0b933dc6a4..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

Suspecting: https://chromium.googlesource.com/chromium/src/+/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the attached screen-cast for reference.
Actual_Video.mov
3.7 MB View Download
Expected_Video.mov
4.1 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/957e18ed8c32465c693652d80e6166cb331e3770

commit 957e18ed8c32465c693652d80e6166cb331e3770
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Sep 26 03:22:07 2018

Print Preview Refresh: More error handling changes

(1) Add 'E' and '+' to the list of excluded keys for number inputs
(2) Blank input handling: Do not disable other settings/print button
    for a blank input. This also fixes a focus traversal issue with
    settings being immediately re-enabled on blur.
(3) Related: When enter is pressed on an input field that may be
    empty, perform the same action as on blur - i.e. reset the cleared
    field to the default value.

Bug:  888916 ,  888986 ,  886800 
Change-Id: I9cf43558fe5353939d9904594d2c39a576d27371
Reviewed-on: https://chromium-review.googlesource.com/1244372
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594208}
[modify] https://crrev.com/957e18ed8c32465c693652d80e6166cb331e3770/chrome/browser/resources/print_preview/new/copies_settings.js
[modify] https://crrev.com/957e18ed8c32465c693652d80e6166cb331e3770/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/957e18ed8c32465c693652d80e6166cb331e3770/chrome/browser/resources/print_preview/new/number_settings_section.js
[modify] https://crrev.com/957e18ed8c32465c693652d80e6166cb331e3770/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/957e18ed8c32465c693652d80e6166cb331e3770/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/957e18ed8c32465c693652d80e6166cb331e3770/chrome/browser/resources/print_preview/new/scaling_settings.js

Comment 2 by rbpotter@chromium.org, Sep 27

Status: Fixed (was: Assigned)
Tested and this is now working in Canary 71.0.3563.0.

Comment 3 by db...@etouch.net, Sep 28

Labels: TE-Verified-M71 TE-Verified-M71.0.3564.0
Update:

Retested and checked above issue and it is fixed on latest canary build #71.0.3564.0 using Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTs) OS.

Kindly check attached screen cast for the same.

Thank you.
Actual_Fix.mov
4.0 MB View Download

Comment 4 by db...@etouch.net, Sep 28

Labels: -TE-Verified-M71.0.3564.0 TE-Verified-71.0.3564.0

Comment 5 by rbpotter@chromium.org, Sep 28

Status: Verified (was: Fixed)
►

Sign in to add a comment